Issue metadata
Sign in to add a comment
|
[User Feedback - Stable/Beta] Suspicious File Prompt: Unable to Keep File and Start Download |
||||||||||||||||||||||
Issue descriptionChrome Version: 65.0.3325.162, 66.0.3359.33 OS: Mac What steps will reproduce the problem? (1) Trigger the suspicious download warning. As an example, attempt to install a 3rd party Chrome theme (example site: https://www.themebeta.com/chrome/theme/938503). (2) Look for option to confirm intent to download file (formerly "Keep"). (3) No option is present, download cannot be started. Clicking the three-dot menu next to "Discard" does not present an option to keep the file, and clicking the "Show All" option opens a blank Downloads page, again missing the option to confirm intent to download. Forum Reports: - https://productforums.google.com/forum/#!topic/chrome/ymei5-5Rnz4 - https://productforums.google.com/forum/#!topic/chrome/zTHxIoZRaHw - https://productforums.google.com/forum/#!topic/chrome/FirvY6Ws5Uc Listnr Reports: - https://listnr.corp.google.com/report/85198498262 - https://listnr.corp.google.com/report/85194797271 - https://listnr.corp.google.com/report/85198513034 Note: some users report the file showing up in chrome://downloads where they can confirm they want to download. With the example Chrome theme above, I wasn't able to see it in chrome://downloads.
,
Mar 19 2018
craigtumblison@ Thanks for the issue. Able to reproduce this issue on Mac OS 10.13.1 and 10.13.3 on the latest Canary 67.0.3375.0 by following the steps mentioned above. Issue is not observed on Mac 10.12.6, Windows 10 and Ubuntu 14.04. Bisect Information: =================== Good Build: 67.0.3364.0 (Revision - 541279) Bad Build : 67.0.3365.0 (Revision - 541679) On executing the per-revision bisect script, below is the Changelog URL: https://chromium.googlesource.com/chromium/src/+log/1cffa8f71564086c45cae117d9321ec52458c6be..405ee5e59e4e3a1f487a700d7e599f6570dfbede From the above Changelog, suspecting the below change: Reviewed-on: https://chromium-review.googlesource.com/951924 sdy@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner. Adding ReleaseBlock-Stable as this is a recent regression. Please feel free to remove it if it is not applicable. Thanks.
,
Mar 19 2018
// Adding to comment #2. Tested this issue on reported versions latest Stable 65.0.3325.162 and Beta 66.0.3359.33 and unable to reproduce the issue. Issue is only observed on the latest Canary 67.0.3375.0. Can observe the 'Continue' button on the download tray in Stable and Beta builds, whereas this button is not observed on Canary. Attached are the screen shots for reference. Thanks...
,
Mar 19 2018
Thanks susan.boorgula@! I think this may be related to the #mac-md-download-shelf flag. Would you be able to retry your reproduction steps on stable / beta with that flag intentionally enabled (instead of "default")? Thanks!
,
Mar 19 2018
This is either related to my change or my responsibility to fix. Removing RBS because this already affects stable, but it's still P1.
,
Mar 21 2018
,
Mar 21 2018
,
Mar 21 2018
,
Mar 21 2018
,
Mar 22 2018
Issue 824473 has been merged into this issue.
,
Mar 22 2018
A user reported that they also spotted this issue on the latest Windows Canary build, so adding the Windows label for the moment. I don't have a Windows device handy to verify though =\
,
Mar 22 2018
Re. #11, this breakage is in Mac-specific code. Windows would have to be a separate issue :/. I'm going to call issue 810782 the official bug for the non-Mac variant of this. A CL is in review, by the way: https://chromium-review.googlesource.com/c/chromium/src/+/973892
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/620b2495863dbfbab8023cea95b49a379ee99f0f commit 620b2495863dbfbab8023cea95b49a379ee99f0f Author: Sidney San Martín <sdy@chromium.org> Date: Fri Mar 23 20:02:11 2018 Add a "continue" button instead of the menu to dangerous-but-not-malicious downloads Bug: 823108 Change-Id: Ie1c4d5ee7fc63ea56f2a25506bab14a7a4137b87 Reviewed-on: https://chromium-review.googlesource.com/973892 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#545562} [modify] https://crrev.com/620b2495863dbfbab8023cea95b49a379ee99f0f/chrome/browser/download/download_shelf_context_menu.cc [modify] https://crrev.com/620b2495863dbfbab8023cea95b49a379ee99f0f/chrome/browser/download/download_shelf_context_menu.h [modify] https://crrev.com/620b2495863dbfbab8023cea95b49a379ee99f0f/chrome/browser/ui/cocoa/download/md_download_item_view.mm
,
Mar 23 2018
This fix will be in the next Canary. I'll request a merge next week if everything looks good.
,
Mar 26 2018
The NextAction date has arrived: 2018-03-26
,
Mar 26 2018
No canary today due to issue 825555.
,
Mar 27 2018
,
Mar 27 2018
The NextAction date has arrived: 2018-03-27
,
Mar 27 2018
Tested this issue on Mac OS 10.12.6 on the reported version 65.0.3325.162 and latest Canary 67.0.3381.0. Able to reproduce this issue on the reported version 65.0.3325.162 and the issue is fixed on the latest Canary 67.0.3381.0 by following the steps mentioned in the original comment. On navigating to the link https://www.themebeta.com/chrome/theme/938503 and clicking on 'Apply Theme' button, can now see an option 'Continue' to download the theme. Attached is the screen shot for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
Mar 27 2018
Great, thanks!
,
Mar 27 2018
,
Mar 27 2018
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 28 2018
,
Mar 29 2018
,
Mar 29 2018
Approving merge to M66. Branch:3359
,
Apr 2 2018
Issue 827786 has been merged into this issue.
,
Apr 2 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 3 2018
Issue 828344 has been merged into this issue.
,
Apr 3 2018
Issue 827874 has been merged into this issue.
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fe8a1cccdbfe6bb30892f42205fdd0980daab55 commit 4fe8a1cccdbfe6bb30892f42205fdd0980daab55 Author: Sidney San Martín <sdy@chromium.org> Date: Tue Apr 03 14:34:16 2018 Add a "continue" button instead of the menu to dangerous-but-not-malicious downloads Bug: 823108 Change-Id: Ie1c4d5ee7fc63ea56f2a25506bab14a7a4137b87 Reviewed-on: https://chromium-review.googlesource.com/973892 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#545562}(cherry picked from commit 620b2495863dbfbab8023cea95b49a379ee99f0f) Reviewed-on: https://chromium-review.googlesource.com/992514 Reviewed-by: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#549} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/4fe8a1cccdbfe6bb30892f42205fdd0980daab55/chrome/browser/download/download_shelf_context_menu.cc [modify] https://crrev.com/4fe8a1cccdbfe6bb30892f42205fdd0980daab55/chrome/browser/download/download_shelf_context_menu.h [modify] https://crrev.com/4fe8a1cccdbfe6bb30892f42205fdd0980daab55/chrome/browser/ui/cocoa/download/md_download_item_view.mm
,
Apr 4 2018
Able to reproduce this issue on Mac OS 10.13.3 on the reported version 65.0.3325.162 and the issue is fixed on the latest Beta 66.0.3359.81 by following the steps mentioned in the original comment. On navigating to the link https://www.themebeta.com/chrome/theme/938503 and clicking on 'Apply Theme' button, can now see an option 'Continue' to download the theme. Attached is the screen shot for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
Apr 4 2018
NOT fixed, this still not working for me.
,
Apr 4 2018
My error, I'm not on 66.3359.81, I cannot see how to obtain this version.
,
Apr 4 2018
Susan in your screenshot 823108-M66-CL.png it looks like it's the old download shelf (non-material design). How does it look with the new download shelf?
,
Apr 6 2018
,
Apr 6 2018
@travismm... Thank you, tried that Beta yesterday but 66.3359.81 wasn't on there but is today, so thank you! The Keep button is back! Problem is fixed. Thanks All.
,
Apr 11 2018
Issue 831672 has been merged into this issue.
,
Apr 26 2018
,
Apr 28 2018
Just updated to Version 66.0.3359.139 on macOS 10.12.6 and seems like this issue was fixed.
,
Apr 30 2018
#39: thanks for confirming :)
,
Apr 30 2018
,
May 1 2018
The Keep button is back for me, on macOS 10.12.6 with Chrome version 66.0.3359.117. Thank you!
,
May 8 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by craigtumblison@chromium.org
, Mar 18 2018516 KB
516 KB View Download