New issue
Advanced search Search tips

Issue 823100 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

V8 correctness failure in configs: x64,ignition:x64,ignition_turbo

Project Member Reported by ClusterFuzz, Mar 18 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6110464921305088

Fuzzer: foozzie_js_mutation
Job Type: v8_foozzie
Platform Id: linux

Crash Type: V8 correctness failure
Crash Address: 
Crash State:
  configs: x64,ignition:x64,ignition_turbo
  sources: 4c7
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=v8_foozzie&range=51990:51991

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6110464921305088

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 18 2018

Labels: Test-Predator-Auto-Owner
Owner: sigurds@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/8a94f074dea97783701bdb3bad52b77e093bb0a5 ([turbofan] Move Number.isInteger to JSCallReducer).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: sigurds@chromium.org
 Issue 823126  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/21dad34f9320af14353014371af287975ca33b68

commit 21dad34f9320af14353014371af287975ca33b68
Author: Sigurd Schneider <sigurds@chromium.org>
Date: Mon Mar 19 09:50:52 2018

[turbofan] Don't treat INFINITY as integer

The fast-path of Number.isInteger and Number.isFinite
both returned true for (-)INFINITY, because kInteger
in the type cache includes both infinities. This CL
uses kSafeInteger range to statically optimize those
two operators.

Bug:  chromium:823151 ,  chromium:823100 
Change-Id: Icab7f305e8c38f25a4b34b88414f0b515bd7a0fb
Reviewed-on: https://chromium-review.googlesource.com/968201
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52010}
[modify] https://crrev.com/21dad34f9320af14353014371af287975ca33b68/src/compiler/simplified-lowering.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/dfc2805ccf7e9fc6795191d0431ed87ba28e37d4

commit dfc2805ccf7e9fc6795191d0431ed87ba28e37d4
Author: Sigurd Schneider <sigurds@chromium.org>
Date: Mon Mar 19 11:44:56 2018

[turbofan] Add test for Number.{isFinite,isInteger} inlining

This adds variants of tests already in our test-suite that
exercise inlining fast-paths of Number.{isFinite,isInteger}.

Bug:  chromium:823151 ,  chromium:823100 
Change-Id: Ibf1192b1325fb4f015acea94053fd51a7a7811a9
Reviewed-on: https://chromium-review.googlesource.com/968361
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52021}
[add] https://crrev.com/dfc2805ccf7e9fc6795191d0431ed87ba28e37d4/test/mjsunit/compiler/number-isfinite-inl.js
[add] https://crrev.com/dfc2805ccf7e9fc6795191d0431ed87ba28e37d4/test/mjsunit/compiler/number-isinteger-inl.js

Project Member

Comment 5 by ClusterFuzz, Mar 20 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5355234717859840 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 6 by ClusterFuzz, Mar 20 2018

ClusterFuzz has detected this issue as fixed in range 52009:52010.

Detailed report: https://clusterfuzz.com/testcase?key=6110464921305088

Fuzzer: foozzie_js_mutation
Job Type: v8_foozzie
Platform Id: linux

Crash Type: V8 correctness failure
Crash Address: 
Crash State:
  configs: x64,ignition:x64,ignition_turbo
  sources: 4c7
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=v8_foozzie&range=51990:51991
Fixed: https://clusterfuzz.com/revisions?job=v8_foozzie&range=52009:52010

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6110464921305088

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment