Extract and encapsulate code from TabGridViewController |
|||
Issue descriptionTabGridViewController is getting pretty big and complex. It's becoming monolithic. Do what we can to reduce this code, keep it tidy, and encapsulate functionality that doesn't belong there. Will use this task to track some work, and close this whenever it feels good enough.
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0107ef9c8760c071045286019bffc856554d162 commit c0107ef9c8760c071045286019bffc856554d162 Author: edchin <edchin@chromium.org> Date: Tue Mar 20 00:58:59 2018 [ios] TabGridNewTabButton This CL extracts lengthly code (~50 lines) from TabGridViewController and encapsulates it into TabGridNewTabButton. Bug: 823079 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If038383deeaedc738849d49a3da31c0afd244e5b Reviewed-on: https://chromium-review.googlesource.com/966697 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544238} [modify] https://crrev.com/c0107ef9c8760c071045286019bffc856554d162/ios/chrome/browser/ui/tab_grid/BUILD.gn [modify] https://crrev.com/c0107ef9c8760c071045286019bffc856554d162/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.h [modify] https://crrev.com/c0107ef9c8760c071045286019bffc856554d162/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm [add] https://crrev.com/c0107ef9c8760c071045286019bffc856554d162/ios/chrome/browser/ui/tab_grid/tab_grid_new_tab_button.h [add] https://crrev.com/c0107ef9c8760c071045286019bffc856554d162/ios/chrome/browser/ui/tab_grid/tab_grid_new_tab_button.mm [modify] https://crrev.com/c0107ef9c8760c071045286019bffc856554d162/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Mar 20 2018
,
Apr 26 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by edchin@chromium.org
, Mar 19 2018