"SystemNetworkContext/NetworkContextConfigurationBrowserTest.ProxyConfig/0" is flaky |
||||||
Issue description"SystemNetworkContext/NetworkContextConfigurationBrowserTest.ProxyConfig/0" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVAsSBUZsYWtlIklTeXN0ZW1OZXR3b3JrQ29udGV4dC9OZXR3b3JrQ29udGV4dENvbmZpZ3VyYXRpb25Ccm93c2VyVGVzdC5Qcm94eUNvbmZpZy8wDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Mar 20 2018
Detected 3 new flakes for test/step "SystemNetworkContext/NetworkContextConfigurationBrowserTest.ProxyConfig/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVAsSBUZsYWtlIklTeXN0ZW1OZXR3b3JrQ29udGV4dC9OZXR3b3JrQ29udGV4dENvbmZpZ3VyYXRpb25Ccm93c2VyVGVzdC5Qcm94eUNvbmZpZy8wDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Mar 21 2018
Detected 6 new flakes for test/step "SystemNetworkContext/NetworkContextConfigurationBrowserTest.ProxyConfig/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVAsSBUZsYWtlIklTeXN0ZW1OZXR3b3JrQ29udGV4dC9OZXR3b3JrQ29udGV4dENvbmZpZ3VyYXRpb25Ccm93c2VyVGVzdC5Qcm94eUNvbmZpZy8wDA. This message was posted automatically by the chromium-try-flakes app.
,
Mar 21 2018
Since no action has been taken, I'm disabling the test.
,
Mar 21 2018
Someone who is OOO generally can't take action. :(
,
Mar 21 2018
Looks like the first failure was Match 16. rhalavati landed 15 Cls on the 15th and 16th, so going through to find the breakage seems like potentially a fair bit of effort. I'll see if I can repro. If not, I'll disable the failing DCHECK until he gets back.
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/daf301c6167457e8f416a12d54a9eecf327e1e14 commit daf301c6167457e8f416a12d54a9eecf327e1e14 Author: Alexander Potapenko <glider@google.com> Date: Wed Mar 21 17:39:40 2018 Disable flaky NetworkContextConfigurationBrowserTest.ProxyConfig BUG= 823077 TBR=rhalavati@chromium.org,eroman@chromium.org Change-Id: I1aa9de378251746704f9c358de45f5ff1540397e Reviewed-on: https://chromium-review.googlesource.com/973607 Reviewed-by: Alexander Potapenko <glider@chromium.org> Commit-Queue: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#544761} [modify] https://crrev.com/daf301c6167457e8f416a12d54a9eecf327e1e14/chrome/browser/net/network_context_configuration_browsertest.cc
,
Mar 22 2018
,
Apr 4 2018
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4196b8354cd1bf4aed168dfc0f21074893059303 commit 4196b8354cd1bf4aed168dfc0f21074893059303 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Apr 09 08:55:34 2018 Fix ProxyResolutionService annotation bug and reactivate tests. Network traffic annotation in ProxyResolutionService was wrongly set in cases where proxy info was fetched through completely synchronous method, causing flaky test failures. The bug is fixed and tests are re-enabled. Bug: 822975 Bug: 826744 Bug: 823077 Change-Id: Ic63301ff053fc9160b1a96372af1ee289342396c Reviewed-on: https://chromium-review.googlesource.com/997656 Reviewed-by: Eric Roman <eroman@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#549130} [modify] https://crrev.com/4196b8354cd1bf4aed168dfc0f21074893059303/chrome/browser/net/network_context_configuration_browsertest.cc [modify] https://crrev.com/4196b8354cd1bf4aed168dfc0f21074893059303/net/proxy_resolution/proxy_resolution_service.cc [modify] https://crrev.com/4196b8354cd1bf4aed168dfc0f21074893059303/net/traffic_annotation/network_traffic_annotation.h
,
Apr 10 2018
There seems to be no more errors. Marking it fixed. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dvadym@chromium.org
, Mar 19 2018Owner: rhalavati@chromium.org
Status: Assigned (was: Untriaged)