Issue metadata
Sign in to add a comment
|
8.8% regression in system_health.memory_mobile at 543593:543639 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 17 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14f46449440000
,
Mar 17 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14f46449440000 [ignition] Set correct expression position for ObjectLiteral keys/values by gsathya@chromium.org https://chromium.googlesource.com/v8/v8/+/acae2f2b65c94e80e26d3135bd3d94c02e689250 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 19 2018
This is just from storing extra metadata in the bytecode for the devtools. I don't think there's anything actionable here. mythi, what do you think we should do here?
,
Mar 19 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16a572f1440000
,
Mar 19 2018
That's a large regression. It is only on yandex on Nexus5X. Since this is on v8:effective_size and not on v8:allocated_object_size, I think adding extra metadata caused allocation of a new page. If this is the case, I think we can ignore this regression. mlippautz@ does this explanation seem reasonable?
,
Mar 19 2018
On v8:allocated_object_size there is a slight regression (~0.2-0.4% or 10-15KB) across several pages around this range: I just started a bisect to be sure they are because of adding additional metadata. https://chromeperf.appspot.com/report?sid=b14edabf2d66544bedac0721266d058ab68de4f37f25179fa7fe353cb0d1a553
,
Mar 19 2018
Yep, the effective size regression looks like one page and you can see it as fyi. I need to double check whether we actually consider lazy committing of OS pages for this metric or just assume that the full page has been mapped into memory.
,
Mar 19 2018
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/16a572f1440000
,
Jun 15 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Mar 17 2018