New issue
Advanced search Search tips

Issue 823043 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

"BrowserTest.WindowOpenClose1" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 17 2018

Issue description

"BrowserTest.WindowOpenClose1" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxCcm93c2VyVGVzdC5XaW5kb3dPcGVuQ2xvc2UxDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by dvadym@chromium.org, Mar 19 2018

The CL https://chromium-review.googlesource.com/c/chromium/src/+/968602 for disabling this test on ChromeOS is in commit queue.

Comment 2 by dvadym@chromium.org, Mar 19 2018

Labels: OS-Chrome
Error message:

[2961:2961:0318/184558.344001:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[2961:2982:0318/184558.506485:WARNING:simple_synchronous_entry.cc(1255)] Could not open platform files for entry.
[2961:3031:0318/184558.615430:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico
[2961:2992:0318/184558.681849:WARNING:discardable_shared_memory_manager.cc(436)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked.
[2961:2961:0318/184558.706492:FATAL:surface_manager.cc(78)] Check failed: surface_map_.empty(). 
#0 0x0000042b67dc base::debug::StackTrace::StackTrace()
#1 0x0000042d152b logging::LogMessage::~LogMessage()
#2 0x000006221fed viz::SurfaceManager::~SurfaceManager()
#3 0x0000061fe6e8 viz::FrameSinkManagerImpl::~FrameSinkManagerImpl()
#4 0x0000061fe85e viz::FrameSinkManagerImpl::~FrameSinkManagerImpl()
#5 0x000002a7d21b content::BrowserMainLoop::ShutdownThreadsAndCleanUp()
#6 0x000002a7fc71 content::BrowserMainRunnerImpl::Shutdown()
#7 0x000002a78f15 content::BrowserMain()
#8 0x00000428145d content::ContentMainRunnerImpl::Run()
#9 0x000006324003 service_manager::Main()
#10 0x00000427fa84 content::ContentMain()
#11 0x0000048ffa5b content::BrowserTestBase::SetUp()

Comment 3 by dvadym@chromium.org, Mar 19 2018

Cc: msw@chromium.org ellyjo...@chromium.org
Owner: jochen@chromium.org
Status: Assigned (was: Untriaged)
Jochen, you're the last how edited this test. Could you please have a look at it or find somebody who knows related code and can fix it?


Comment 4 by dvadym@chromium.org, Mar 19 2018

Labels: -Sheriff-Chromium

Comment 5 by jochen@chromium.org, Mar 19 2018

Cc: jochen@chromium.org
Owner: fsam...@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad3585e2b6d5af6347a2aa2e14ed4bb4087eac52

commit ad3585e2b6d5af6347a2aa2e14ed4bb4087eac52
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Mon Mar 19 14:22:20 2018

Disabling flaky test BrowserTest.WindowOpenClose1 on Chrome OS.

TBR=msw@chromium.org

Bug: 823043
Change-Id: I4c113f6630340907aec7870487176a2046f035ac
Reviewed-on: https://chromium-review.googlesource.com/968602
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544024}
[modify] https://crrev.com/ad3585e2b6d5af6347a2aa2e14ed4bb4087eac52/chrome/browser/ui/browser_browsertest.cc

Comment 7 by msw@chromium.org, Mar 19 2018

I was TBR'ed without being included on the CL, see Issue 500032 for that...
All the failures look like they occurred with various CQ patches applied.

Comment 8 by msw@chromium.org, Mar 20 2018

 Issue 823396  has been merged into this issue.

Comment 9 by msw@chromium.org, Mar 20 2018

 Issue 823396  is also disabling BrowserTest.WindowOpenClose2, maybe we should proactively disable more fixtures or find a fix soon?
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7df68a3747d9f378429fc1855009112298771aeb

commit 7df68a3747d9f378429fc1855009112298771aeb
Author: Karan Bhatia <karandeepb@chromium.org>
Date: Tue Mar 20 19:00:09 2018

Change cited bug ID for disabled BrowserTest.WindowOpenClose2.

BUG=823043

Change-Id: Ibd696afdba897b78fafb1c1a7ca696ce62c44f47
Reviewed-on: https://chromium-review.googlesource.com/971464
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544464}
[modify] https://crrev.com/7df68a3747d9f378429fc1855009112298771aeb/chrome/browser/ui/browser_browsertest.cc

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "BrowserTest.WindowOpenClose2". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxCcm93c2VyVGVzdC5XaW5kb3dPcGVuQ2xvc2UyDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e9cdb9d7f7b4e5548dd769045209fd556f81bf9

commit 8e9cdb9d7f7b4e5548dd769045209fd556f81bf9
Author: Derek Cheng <imcheng@chromium.org>
Date: Tue Jul 24 23:40:21 2018

[Sheriff] Disable flaky test BrowserTest.WindowOpenClose2 on Windows.

It started flaking on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/70474

TBR=fsamuel

Bug: 823043
Change-Id: I23a000160c81ed75a277331a6739095958ff6e77
Reviewed-on: https://chromium-review.googlesource.com/1149097
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577730}
[modify] https://crrev.com/8e9cdb9d7f7b4e5548dd769045209fd556f81bf9/chrome/browser/ui/browser_browsertest.cc

Labels: -Sheriff-Chromium
Labels: Sheriff-Chromium
Detected 7 new flakes for test/step "BrowserTest.WindowOpenClose2". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxCcm93c2VyVGVzdC5XaW5kb3dPcGVuQ2xvc2UyDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "BrowserTest.WindowOpenClose2". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxCcm93c2VyVGVzdC5XaW5kb3dPcGVuQ2xvc2UyDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Appears to be flaking on Linux too, will disable it there as well (https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxCcm93c2VyVGVzdC5XaW5kb3dPcGVuQ2xvc2UyDA):

[ RUN      ] BrowserTest.WindowOpenClose2
Xlib:  extension "RANDR" missing on display ":99".
[3802:3802:0725/103642.253284:ERROR:browser_dm_token_storage_linux.cc(93)] Error: /etc/machine-id contains 32 characters (32 were expected).
[3802:3840:0725/103642.330012:ERROR:bus.cc(394)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3802:3802:0725/103642.330676:WARNING:password_store_factory.cc(250)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
(browser_tests:3802): LIBDBUSMENU-GLIB-WARNING **: Unable to get session bus: Unknown or unsupported transport 'disabled' for address 'disabled:'
[3838:3838:0725/103642.416863:WARNING:owning_audio_manager_accessor.cc(80)] Out of process audio service initializing.
[3837:3889:0725/103642.446831:WARNING:file_path_watcher_linux.cc(656)] Watch failed for /etc/../run/resolvconf: No such file or directory (2)
[3802:3802:0725/103642.468721:WARNING:gaia_auth_fetcher.cc(924)] Could not reach Google Accounts servers: errno -11
[3802:3895:0725/103642.668714:WARNING:embedded_test_server.cc(238)] Request not handled. Returning 404: /favicon.ico
[3802:3802:0725/103642.742405:FATAL:surface_manager.cc(83)] Check failed: surface_map_.empty().
#0 0x00000638b69c base::debug::StackTrace::StackTrace()
#1 0x0000062d5e9b logging::LogMessage::~LogMessage()
#2 0x00000827b03a viz::SurfaceManager::~SurfaceManager()
#3 0x00000824dc89 viz::FrameSinkManagerImpl::~FrameSinkManagerImpl()
#4 0x00000824dcfe viz::FrameSinkManagerImpl::~FrameSinkManagerImpl()
#5 0x0000047551e1 content::BrowserMainLoop::ShutdownThreadsAndCleanUp()
#6 0x000004757e58 content::BrowserMainRunnerImpl::Shutdown()
#7 0x000004750845 content::BrowserMain()
#8 0x000006228d74 content::ContentMainRunnerImpl::Run()
#9 0x0000083fb0e9 service_manager::Main()
#10 0x000006226dd1 content::ContentMain()
#11 0x00000698e99e content::BrowserTestBase::SetUp()
#12 0x0000063d6892 InProcessBrowserTest::SetUp()
#13 0x000003a099dd testing::Test::Run()
#14 0x000003a0a640 testing::TestInfo::Run()
#15 0x000003a0ab57 testing::TestCase::Run()
#16 0x000003a16457 testing::internal::UnitTestImpl::RunAllTests()
#17 0x000003a15fcd testing::UnitTest::Run()
#18 0x0000063eedd1 base::TestSuite::Run()
#19 0x0000062b2fe2 ChromeTestSuiteRunner::RunTestSuite()
#20 0x0000069b44f5 content::LaunchTests()
#21 0x0000062b3483 LaunchChromeTests()
#22 0x0000062b2f6e main
#23 0x7f0fb0f0ef45 __libc_start_main
#24 0x00000247902a _start
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67d004a5e3c056a4b97ffef3e6bc682656ea273c

commit 67d004a5e3c056a4b97ffef3e6bc682656ea273c
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Thu Jul 26 14:39:31 2018

[Sheriff] Disable flaky test BrowserTest.WindowOpenClose2 on Linux

Test is flaking consistently on the CQ:
https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxCcm93c2VyVGVzdC5XaW5kb3dPcGVuQ2xvc2UyDA

TBR=fsamuel@chromium.org

Bug: 823043
Change-Id: I6103eb9fcb95e9e3afc77ab9da1740391fe5d211
Reviewed-on: https://chromium-review.googlesource.com/1151387
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578299}
[modify] https://crrev.com/67d004a5e3c056a4b97ffef3e6bc682656ea273c/chrome/browser/ui/browser_browsertest.cc

Labels: -Sheriff-Chromium
Components: Internals>Services>Viz
Labels: OS-Linux
Cc: kylec...@chromium.org samans@chromium.org
Owner: moh...@chromium.org
This is surface reference related. I'm reassigning to mohsen@. Please ask kylechar@, samans@ or myself for questions.

Sign in to add a comment