New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823041 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

ASSERT: mSymbolType == SymbolType::AngleInternal

Project Member Reported by ClusterFuzz, Mar 17 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6214587947679744

Fuzzer: libFuzzer_angle_translator_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  mSymbolType == SymbolType::AngleInternal
  sh::TSymbol::name
  sh::DecorateVariableIfNeeded
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=543606:543610

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6214587947679744

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 17 2018

Labels: Test-Predator-Auto-Owner
Owner: oetu...@nvidia.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/angle/angle/+/d4bd963ff82400e72105a541bf131d4ce2f45619 (Don't use TIntermSymbol nodes for function parameters).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 2 by oetu...@nvidia.com, Mar 19 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/40b1c77070fd599823aec3f82b5e1cfe601757f7

commit 40b1c77070fd599823aec3f82b5e1cfe601757f7
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Wed Mar 21 17:59:05 2018

Fix asserts related to writing nameless parameters in HLSL

We rely on TSymbol::name() to generate names also for nameless
parameters. Fix asserts to reflect this.

BUG= chromium:823041 
TEST=angle_unittests

Change-Id: Ie9b8253a150e79965bf85d8a7f36643ada6c54cc
Reviewed-on: https://chromium-review.googlesource.com/968242
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

[modify] https://crrev.com/40b1c77070fd599823aec3f82b5e1cfe601757f7/src/compiler/translator/UtilsHLSL.cpp
[modify] https://crrev.com/40b1c77070fd599823aec3f82b5e1cfe601757f7/src/tests/compiler_tests/HLSLOutput_test.cpp
[modify] https://crrev.com/40b1c77070fd599823aec3f82b5e1cfe601757f7/src/compiler/translator/Symbol.h
[modify] https://crrev.com/40b1c77070fd599823aec3f82b5e1cfe601757f7/src/compiler/translator/Symbol.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f0eb38aaf63c972ee2cb536798f1900a7f9f38f

commit 6f0eb38aaf63c972ee2cb536798f1900a7f9f38f
Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Mar 21 19:13:28 2018

Roll src/third_party/angle/ 115b2c4a2..40b1c7707 (3 commits)

https://chromium.googlesource.com/angle/angle.git/+log/115b2c4a2fc6..40b1c77070fd

$ git log 115b2c4a2..40b1c7707 --date=short --no-merges --format='%ad %ae %s'
2018-03-19 oetuaho Fix asserts related to writing nameless parameters in HLSL
2018-03-15 jiawei.shao ES31: Support queries on primitives generated by geometry shader
2018-03-19 oetuaho Share parameter arrays more between built-in functions

Created with:
  roll-dep src/third_party/angle
BUG= chromium:823041 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I262820d80f2f8c21158bf71c42c4136c47a8ab09
Reviewed-on: https://chromium-review.googlesource.com/973842
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544795}
[modify] https://crrev.com/6f0eb38aaf63c972ee2cb536798f1900a7f9f38f/DEPS

Project Member

Comment 5 by ClusterFuzz, Mar 22 2018

ClusterFuzz has detected this issue as fixed in range 544794:544808.

Detailed report: https://clusterfuzz.com/testcase?key=6214587947679744

Fuzzer: libFuzzer_angle_translator_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  mSymbolType == SymbolType::AngleInternal
  sh::TSymbol::name
  sh::DecorateVariableIfNeeded
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=543606:543610
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=544794:544808

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6214587947679744

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Mar 22 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6214587947679744 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment