New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 823039 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Security



Sign in to add a comment

Stack-use-after-return in TDiagnostics::writeDebug

Project Member Reported by ClusterFuzz, Mar 17 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5532621564805120

Fuzzer: libFuzzer_gpu_swiftshader_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Stack-use-after-return READ 8
Crash Address: 0x7f59f7764560
Crash State:
  TDiagnostics::writeDebug
  TParseContext::trace
  Trace
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=543602:543606

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5532621564805120

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 17 2018

Components: Internals>GPU>SwiftShader
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Mar 17 2018

Cc: capn@google.com sugoi@google.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Fix texture upload and internalformat handling. by capn@google.com - https://swiftshader.googlesource.com/SwiftShader/+/3b4a25c5365486981157f8ba9a2aee539c162a0d

Texture rectangle related fixes and associated tests by sugoi@google.com - https://swiftshader.googlesource.com/SwiftShader/+/0988fb8e9a9bc6c1e56f4b620b63e07891daf1b0

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 17 2018

Labels: M-67
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 17 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 17 2018

Labels: Pri-1

Comment 6 by est...@chromium.org, Mar 17 2018

Owner: capn@chromium.org
Status: Assigned (was: Untriaged)
capn, can you please take a look? Thanks!

Comment 7 by sugoi@chromium.org, Mar 19 2018

Labels: -Pri-1 -Security_Impact-Head -Security_Severity-High -ReleaseBlock-Stable Security_Impact-None Security_Severity-Low ReleaseBlock-NA Pri-2
It's hitting an UNIMPLEMENTED statement here:
https://swiftshader.googlesource.com/SwiftShader/+/a124f042c3b49cf1917a070ff66c8b333f9d48d7/src/OpenGL/libGLESv2/libGLESv2.cpp#986

This is neither a problem in itself nor is it a security issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Mar 19 2018

Labels: -ReleaseBlock-NA
Project Member

Comment 9 by ClusterFuzz, Mar 28 2018

ClusterFuzz has detected this issue as fixed in range 546342:546367.

Detailed report: https://clusterfuzz.com/testcase?key=5532621564805120

Fuzzer: libFuzzer_gpu_swiftshader_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Stack-use-after-return READ 8
Crash Address: 0x7f59f7764560
Crash State:
  TDiagnostics::writeDebug
  TParseContext::trace
  Trace
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=543602:543606
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=546342:546367

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5532621564805120

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Mar 28 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5532621564805120 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 12 by sheriffbot@chromium.org, Mar 29 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 13 by sheriffbot@chromium.org, Jul 5

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment