New issue
Advanced search Search tips

Issue 823036 link

Starred by 6 users
Status: Assigned
Owner:
hta@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on:
issue 452623


Sign in to add a comment

Deprecate and remove local modification of local SDP

Project Member Reported by hta@chromium.org, Mar 17 2018 
Feature description:

The WebRTC specification forbids modification of SDP between CreateOffer() and SetLocalDescription().
See point 2.1.3 in http://w3c.github.io/webrtc-pc/#set-description.
Hand-written SDP has been used in the past. This bug tracks the removal of that feature.

Eng owner: hta@chromium.org
Product owner: huib@chromium.org

Design doc: None

Comment 1 by hta@chromium.org, Mar 17 2018

Blockedon: 452623
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4237031b1cd4e7b5007964b082fe3e33863fc51

commit f4237031b1cd4e7b5007964b082fe3e33863fc51
Author: Harald Alvestrand <hta@chromium.org>
Date: Thu Mar 22 18:51:11 2018

Add memory of last SDP offer/answer created

This adds internal slots "LastOffer" and "LastAnswer", and uses
those to check that SetLocalDescription uses an unchanged SDP offer/answer.

Because modification of SDP is suspected to be used in a number of places,
this change only rejects SDP with modified fingerprints (which would fail
anyway), but merely counts the usage for other modifications.

Bug: chromium:823036
Change-Id: I0c978d5ff3e63b0afab3ec02334c57a5aaa94cdd
Reviewed-on: https://chromium-review.googlesource.com/966441
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545175}
[modify] https://crrev.com/f4237031b1cd4e7b5007964b082fe3e33863fc51/content/test/data/media/peerconnection-call.html
[modify] https://crrev.com/f4237031b1cd4e7b5007964b082fe3e33863fc51/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt
[modify] https://crrev.com/f4237031b1cd4e7b5007964b082fe3e33863fc51/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-offer-expected.txt
[modify] https://crrev.com/f4237031b1cd4e7b5007964b082fe3e33863fc51/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-offer.html
[modify] https://crrev.com/f4237031b1cd4e7b5007964b082fe3e33863fc51/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-pranswer-expected.txt
[modify] https://crrev.com/f4237031b1cd4e7b5007964b082fe3e33863fc51/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/f4237031b1cd4e7b5007964b082fe3e33863fc51/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
[modify] https://crrev.com/f4237031b1cd4e7b5007964b082fe3e33863fc51/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescription.cpp
[modify] https://crrev.com/f4237031b1cd4e7b5007964b082fe3e33863fc51/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescription.h
[modify] https://crrev.com/f4237031b1cd4e7b5007964b082fe3e33863fc51/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.cpp
[modify] https://crrev.com/f4237031b1cd4e7b5007964b082fe3e33863fc51/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestPromiseImpl.cpp
[modify] https://crrev.com/f4237031b1cd4e7b5007964b082fe3e33863fc51/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/f4237031b1cd4e7b5007964b082fe3e33863fc51/tools/metrics/histograms/enums.xml

Comment 3 by benhenry@google.com, Jan 11

Labels: Pri-2
Setting defect without priority to Pri-2.
►

Sign in to add a comment