New issue
Advanced search Search tips

Issue 822990 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Implement task cancellation in update_client

Project Member Reported by sorin@chromium.org, Mar 17 2018

Issue description

It is needed for Android task scheduling.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac01799a7a69e348f68e9c12c886ee7afc126997

commit ac01799a7a69e348f68e9c12c886ee7afc126997
Author: Sorin Jianu <sorin@chromium.org>
Date: Mon Mar 19 17:47:43 2018

Replace the iterator with a reference in the update_client::UpdateEngine.

Since the UpdateContext is now a ref counted type, using the iterator
adds an unnecessary level of obfuscation.

Also, to implement task cancellation, a mechanism is needed to relate
the update task and its context, and the iterator is not appropriate
for that.

TBR: waffles
Bug: 822990
Change-Id: I8db51b24e4ef0f9b30f434820fa6d3bd1b066e98
Reviewed-on: https://chromium-review.googlesource.com/966966
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544069}
[modify] https://crrev.com/ac01799a7a69e348f68e9c12c886ee7afc126997/components/update_client/update_engine.cc
[modify] https://crrev.com/ac01799a7a69e348f68e9c12c886ee7afc126997/components/update_client/update_engine.h

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c426d2a2ca050e2fbc739dbaccfeece8bc0ceb3

commit 9c426d2a2ca050e2fbc739dbaccfeece8bc0ceb3
Author: Sorin Jianu <sorin@chromium.org>
Date: Wed Mar 21 02:41:15 2018

Changed from std::set to std::map as a container for UpdateContext.

An UpdateContext is looked up by its session id.

TBR: waffles
Bug: 822990
Change-Id: I0fb88ad98272082a725e1cd74bbc2fa4303e75fc
Reviewed-on: https://chromium-review.googlesource.com/971262
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544623}
[modify] https://crrev.com/9c426d2a2ca050e2fbc739dbaccfeece8bc0ceb3/components/update_client/update_engine.cc
[modify] https://crrev.com/9c426d2a2ca050e2fbc739dbaccfeece8bc0ceb3/components/update_client/update_engine.h

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d271f4b26d827195328939f220b084c49567af1c

commit d271f4b26d827195328939f220b084c49567af1c
Author: Sorin Jianu <sorin@chromium.org>
Date: Thu Apr 05 22:33:47 2018

Implements Pause/Resume for the URLRequestPostInterceptor.

This allows for temporarily stopping the network so that
update engine tasks can be deterministically cancelled in a unit test.

Bug: 822990
Change-Id: I8d9cf5676c2f1d3211fe392e130eb48052307605
Reviewed-on: https://chromium-review.googlesource.com/998737
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548592}
[modify] https://crrev.com/d271f4b26d827195328939f220b084c49567af1c/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/d271f4b26d827195328939f220b084c49567af1c/components/update_client/url_request_post_interceptor.cc
[modify] https://crrev.com/d271f4b26d827195328939f220b084c49567af1c/components/update_client/url_request_post_interceptor.h

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d67a01857edd6ad282f8e77696e7683472ae686

commit 8d67a01857edd6ad282f8e77696e7683472ae686
Author: Sorin Jianu <sorin@chromium.org>
Date: Mon Apr 09 06:29:44 2018

Add a unit test for resetting the update checker while it is paused.

TBR: waffles
Bug: 822990
Change-Id: I29c82551b2fbc5f7f8f8d5f8e87e88808fbf5d6a
Reviewed-on: https://chromium-review.googlesource.com/1001392
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549114}
[modify] https://crrev.com/8d67a01857edd6ad282f8e77696e7683472ae686/components/update_client/update_checker_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee5c0dbd112d7af40d6197499688f4eff4296fbb

commit ee5c0dbd112d7af40d6197499688f4eff4296fbb
Author: Sorin Jianu <sorin@chromium.org>
Date: Thu Apr 12 23:38:47 2018

Clean up how is_handled is implemented in the UpdateClient state machine.

This is a mechanical change. The intention is to make it more obvious how
a transition to a final state occurs and what is_handled means.

Bug: 822990
Change-Id: I00bff79618e1128617f5655010a17dd8eadd954e
Reviewed-on: https://chromium-review.googlesource.com/1011243
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550413}
[modify] https://crrev.com/ee5c0dbd112d7af40d6197499688f4eff4296fbb/components/update_client/component.cc
[modify] https://crrev.com/ee5c0dbd112d7af40d6197499688f4eff4296fbb/components/update_client/component.h

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee5c0dbd112d7af40d6197499688f4eff4296fbb

commit ee5c0dbd112d7af40d6197499688f4eff4296fbb
Author: Sorin Jianu <sorin@chromium.org>
Date: Thu Apr 12 23:38:47 2018

Clean up how is_handled is implemented in the UpdateClient state machine.

This is a mechanical change. The intention is to make it more obvious how
a transition to a final state occurs and what is_handled means.

Bug: 822990
Change-Id: I00bff79618e1128617f5655010a17dd8eadd954e
Reviewed-on: https://chromium-review.googlesource.com/1011243
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550413}
[modify] https://crrev.com/ee5c0dbd112d7af40d6197499688f4eff4296fbb/components/update_client/component.cc
[modify] https://crrev.com/ee5c0dbd112d7af40d6197499688f4eff4296fbb/components/update_client/component.h

Sign in to add a comment