Polish Recent Tabs Cells
CLs related to this issue: https://chromium-review.googlesource.com/c/chromium/src/+/1030764 https://chromium-review.googlesource.com/c/chromium/src/+/1017918
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0f22afa25b4df010fbf463447d2121f37bf5c3d commit a0f22afa25b4df010fbf463447d2121f37bf5c3d Author: Chris Lu <thegreenfrog@chromium.org> Date: Wed May 02 01:35:57 2018 [ios] Make text-only cell multi-lined and styled properly TableViewTextItem text used to be a single line that was cropped once it reached the end of the screen. Also sets the right color for the cells. Screenshots: https://drive.google.com/file/d/1ZS_bk01JU38rbC5nxMKK76yhj62VU_XU/view?usp=sharing https://drive.google.com/file/d/1p1Qv27DOP1ZP97F2ZR7X8yg2DpKDSOIC/view?usp=sharing https://drive.google.com/file/d/1f4gigdxaV58Scbfeuz-3GexEPxLNCCY4/view?usp=sharing https://drive.google.com/file/d/1eet07y_X2UXXk15x0Tcwm3xCw1SlH_bt/view?usp=sharing Bug: 822988 Change-Id: If5f7a25505e6014adbd3068f9c4f5b1868cd4f18 Reviewed-on: https://chromium-review.googlesource.com/1026807 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#555274} [modify] https://crrev.com/a0f22afa25b4df010fbf463447d2121f37bf5c3d/ios/chrome/browser/ui/history/history_table_view_controller.mm [modify] https://crrev.com/a0f22afa25b4df010fbf463447d2121f37bf5c3d/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm [modify] https://crrev.com/a0f22afa25b4df010fbf463447d2121f37bf5c3d/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm [modify] https://crrev.com/a0f22afa25b4df010fbf463447d2121f37bf5c3d/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.h [modify] https://crrev.com/a0f22afa25b4df010fbf463447d2121f37bf5c3d/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.mm [modify] https://crrev.com/a0f22afa25b4df010fbf463447d2121f37bf5c3d/ios/chrome/browser/ui/table_view/cells/table_view_text_item.h [modify] https://crrev.com/a0f22afa25b4df010fbf463447d2121f37bf5c3d/ios/chrome/browser/ui/table_view/cells/table_view_text_item.mm
The NextAction date has arrived: 2018-05-09
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/101061b765f0002831c6f8ae0270a5d8430cf589 commit 101061b765f0002831c6f8ae0270a5d8430cf589 Author: Chris Lu <thegreenfrog@chromium.org> Date: Wed May 16 23:06:00 2018 [ios] Style Recent Tabs Signed In Sync Off Cell Creates new tableviewtextactionbuttonitem and tableviewtextactionbuttoncell for signed in, but not synced, state in recent tabs. Can be reused for signin promo when that time comes. Screenshot: https://drive.google.com/open?id=14BFzN7256LtFGvGUl2yU9HDOFqaBQisJ Bug: 822988 Change-Id: I9634282b7e65d2d740db43f6425413a69b25b5b8 Reviewed-on: https://chromium-review.googlesource.com/1048873 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#559324} [modify] https://crrev.com/101061b765f0002831c6f8ae0270a5d8430cf589/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm [modify] https://crrev.com/101061b765f0002831c6f8ae0270a5d8430cf589/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm [modify] https://crrev.com/101061b765f0002831c6f8ae0270a5d8430cf589/ios/chrome/browser/ui/table_view/cells/BUILD.gn [add] https://crrev.com/101061b765f0002831c6f8ae0270a5d8430cf589/ios/chrome/browser/ui/table_view/cells/table_view_text_button_item.h [add] https://crrev.com/101061b765f0002831c6f8ae0270a5d8430cf589/ios/chrome/browser/ui/table_view/cells/table_view_text_button_item.mm [add] https://crrev.com/101061b765f0002831c6f8ae0270a5d8430cf589/ios/chrome/browser/ui/table_view/cells/table_view_text_button_item_unittest.mm
Each polish issue should have its own bug now
Comment 1 by rohitrao@chromium.org
, Mar 22 2018