New issue
Advanced search Search tips

Issue 822987 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
Q2



Sign in to add a comment

Collections: Polish Recent Tabs Headers

Project Member Reported by sczs@chromium.org, Mar 17 2018

Issue description

Polish recent tabs related headers
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4353507834c1e21f17c8848b99febf1cf1fb528b

commit 4353507834c1e21f17c8848b99febf1cf1fb528b
Author: sczs <sczs@chromium.org>
Date: Tue Mar 27 17:42:58 2018

[ios] Adds a highlight tap animation to TableViewTextHeaderFooterView

Bug:  822987 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7aa275e08846b1ea9b067de343f6a631a56db566
Reviewed-on: https://chromium-review.googlesource.com/972163
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546154}
[modify] https://crrev.com/4353507834c1e21f17c8848b99febf1cf1fb528b/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/4353507834c1e21f17c8848b99febf1cf1fb528b/ios/chrome/browser/ui/table_view/cells/table_view_text_header_footer_item.h
[modify] https://crrev.com/4353507834c1e21f17c8848b99febf1cf1fb528b/ios/chrome/browser/ui/table_view/cells/table_view_text_header_footer_item.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37e471f27c2d17f404eb08d6280f43cf8399ac0f

commit 37e471f27c2d17f404eb08d6280f43cf8399ac0f
Author: sczs <sczs@chromium.org>
Date: Tue Mar 27 19:23:22 2018

[ios] Adds Recent Tabs and TableView assets.

Bug:  822987 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icb56645549412651656dafa6ecbbf869d3cba2b4
Reviewed-on: https://chromium-review.googlesource.com/982364
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546199}
[add] https://crrev.com/37e471f27c2d17f404eb08d6280f43cf8399ac0f/ios/chrome/browser/ui/recent_tabs/resources/BUILD.gn
[add] https://crrev.com/37e471f27c2d17f404eb08d6280f43cf8399ac0f/ios/chrome/browser/ui/recent_tabs/resources/show_history.imageset/Contents.json
[add] https://crrev.com/37e471f27c2d17f404eb08d6280f43cf8399ac0f/ios/chrome/browser/ui/recent_tabs/resources/show_history.imageset/show_history.png
[add] https://crrev.com/37e471f27c2d17f404eb08d6280f43cf8399ac0f/ios/chrome/browser/ui/recent_tabs/resources/show_history.imageset/show_history@2x.png
[add] https://crrev.com/37e471f27c2d17f404eb08d6280f43cf8399ac0f/ios/chrome/browser/ui/recent_tabs/resources/show_history.imageset/show_history@3x.png
[add] https://crrev.com/37e471f27c2d17f404eb08d6280f43cf8399ac0f/ios/chrome/browser/ui/table_view/cells/resources/BUILD.gn
[add] https://crrev.com/37e471f27c2d17f404eb08d6280f43cf8399ac0f/ios/chrome/browser/ui/table_view/cells/resources/table_view_cell_chevron.imageset/Contents.json
[add] https://crrev.com/37e471f27c2d17f404eb08d6280f43cf8399ac0f/ios/chrome/browser/ui/table_view/cells/resources/table_view_cell_chevron.imageset/table_view_cell_chevron.png
[add] https://crrev.com/37e471f27c2d17f404eb08d6280f43cf8399ac0f/ios/chrome/browser/ui/table_view/cells/resources/table_view_cell_chevron.imageset/table_view_cell_chevron@2x.png
[add] https://crrev.com/37e471f27c2d17f404eb08d6280f43cf8399ac0f/ios/chrome/browser/ui/table_view/cells/resources/table_view_cell_chevron.imageset/table_view_cell_chevron@3x.png
[add] https://crrev.com/37e471f27c2d17f404eb08d6280f43cf8399ac0f/ios/chrome/browser/ui/table_view/cells/resources/table_view_cell_favicon_background.imageset/Contents.json
[add] https://crrev.com/37e471f27c2d17f404eb08d6280f43cf8399ac0f/ios/chrome/browser/ui/table_view/cells/resources/table_view_cell_favicon_background.imageset/table_view_cell_favicon_background.png
[add] https://crrev.com/37e471f27c2d17f404eb08d6280f43cf8399ac0f/ios/chrome/browser/ui/table_view/cells/resources/table_view_cell_favicon_background.imageset/table_view_cell_favicon_background@2x.png
[add] https://crrev.com/37e471f27c2d17f404eb08d6280f43cf8399ac0f/ios/chrome/browser/ui/table_view/cells/resources/table_view_cell_favicon_background.imageset/table_view_cell_favicon_background@3x.png

Comment 3 by cmasso@google.com, Apr 5 2018

Labels: Pri-2

Comment 4 by sczs@chromium.org, Apr 11 2018

Labels: -Type-Bug Type-Task

Comment 5 by sczs@chromium.org, Apr 11 2018

Issue 831120 has been merged into this issue.

Comment 6 by sczs@chromium.org, Apr 11 2018

Cc: sczs@chromium.org
Owner: thegreenfrog@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment