New issue
Advanced search Search tips

Issue 822979 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Make |ArcWallpaperController| work under Mash

Project Member Reported by wzang@chromium.org, Mar 16 2018

Issue description

Currently, ArcWallpaperService has several functionalities not working under Mash. They should be converted to mojo interface, and the //ash/wallpaper dependency should be completely removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7143c9e428aff36bbe42398cd3e77c065489d3a3

commit 7143c9e428aff36bbe42398cd3e77c065489d3a3
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue Mar 20 07:06:48 2018

cros: Create mojo interface for |ArcWallpaperService|

This CL tries to remove the dependency of //ash/wallpaper in
|ArcWallpaperService|. The behavior should be kept exactly the same.

Bug:  822979 
Test: unit_tests, ash_unittests and an Android wallpaper app on device
Change-Id: I925b005b13c5f5fd5847e2dfa01701ff9130d0ab
Reviewed-on: https://chromium-review.googlesource.com/967431
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544302}
[modify] https://crrev.com/7143c9e428aff36bbe42398cd3e77c065489d3a3/ash/public/interfaces/wallpaper.mojom
[modify] https://crrev.com/7143c9e428aff36bbe42398cd3e77c065489d3a3/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/7143c9e428aff36bbe42398cd3e77c065489d3a3/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/7143c9e428aff36bbe42398cd3e77c065489d3a3/ash/wallpaper/wallpaper_controller_observer.h
[modify] https://crrev.com/7143c9e428aff36bbe42398cd3e77c065489d3a3/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/7143c9e428aff36bbe42398cd3e77c065489d3a3/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc
[modify] https://crrev.com/7143c9e428aff36bbe42398cd3e77c065489d3a3/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.h
[modify] https://crrev.com/7143c9e428aff36bbe42398cd3e77c065489d3a3/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service_unittest.cc
[modify] https://crrev.com/7143c9e428aff36bbe42398cd3e77c065489d3a3/chrome/browser/ui/app_list/app_list_view_delegate.cc
[modify] https://crrev.com/7143c9e428aff36bbe42398cd3e77c065489d3a3/chrome/browser/ui/app_list/app_list_view_delegate.h
[modify] https://crrev.com/7143c9e428aff36bbe42398cd3e77c065489d3a3/chrome/browser/ui/ash/test_wallpaper_controller.cc
[modify] https://crrev.com/7143c9e428aff36bbe42398cd3e77c065489d3a3/chrome/browser/ui/ash/test_wallpaper_controller.h
[modify] https://crrev.com/7143c9e428aff36bbe42398cd3e77c065489d3a3/chrome/browser/ui/ash/wallpaper_controller_client.cc
[modify] https://crrev.com/7143c9e428aff36bbe42398cd3e77c065489d3a3/chrome/browser/ui/ash/wallpaper_controller_client.h

Comment 2 by wzang@chromium.org, Mar 29 2018

Status: Fixed (was: Started)

Sign in to add a comment