Testing: content verification mode setup for browser tests |
|
Issue descriptionHave a way to deterministic-ally override content verification mode during test runs. This is because we cannot (as we should not) tweak the mode using command line flags. Tests currently use kExtensionContentVerification, (e.g. see content_verifier_hash_fetch_behavior_browsertest.cc) which isn't enough for official build and/or windows. I'm going to add overrides for tests. /cc proberge@ for FYI.
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c7b9d22337c73c38d53c8759a2fcf5dae788131 commit 4c7b9d22337c73c38d53c8759a2fcf5dae788131 Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Tue Mar 20 02:13:38 2018 CV: Correctly override content verification modes in tests. Content verification mode is currently dependent on flag + field trial + os + google branded-ness. This means using flags to control verification mode from tests isn't going to produce desired outcome. Provide a way for tests to override this mode instead and use them in browser_tests. Bug: 822970 Test: No visible change. Change-Id: Ie764684d9acd56f3479d8d38f14fd02335160434 Reviewed-on: https://chromium-review.googlesource.com/967055 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544262} [modify] https://crrev.com/4c7b9d22337c73c38d53c8759a2fcf5dae788131/chrome/browser/extensions/chrome_content_verifier_delegate.cc [modify] https://crrev.com/4c7b9d22337c73c38d53c8759a2fcf5dae788131/chrome/browser/extensions/chrome_content_verifier_delegate.h [modify] https://crrev.com/4c7b9d22337c73c38d53c8759a2fcf5dae788131/chrome/browser/extensions/content_verifier_browsertest.cc [modify] https://crrev.com/4c7b9d22337c73c38d53c8759a2fcf5dae788131/chrome/browser/extensions/content_verifier_hash_fetch_behavior_browsertest.cc |
|
►
Sign in to add a comment |
|
Comment 1 by proberge@chromium.org
, Mar 19 2018