We need these to use ash frame for ARC++
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/464a588722dbc27fa7e9acdec1cd7708351ddccf commit 464a588722dbc27fa7e9acdec1cd7708351ddccf Author: Mitsuru Oshima <oshima@chromium.org> Date: Sat Mar 17 01:05:57 2018 Add menu/zoom icons. These will be used for ARC++ windows. This also moves the back button asset to ash/public/cpp/vector_icons where they should be. BUG= 822960 Change-Id: Ie26b11c1eacbef8cce9e6f07a17ba8daf2c80754 Reviewed-on: https://chromium-review.googlesource.com/966942 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#543895} [modify] https://crrev.com/464a588722dbc27fa7e9acdec1cd7708351ddccf/ash/frame/caption_buttons/frame_back_button.cc [modify] https://crrev.com/464a588722dbc27fa7e9acdec1cd7708351ddccf/ash/public/cpp/vector_icons/BUILD.gn [rename] https://crrev.com/464a588722dbc27fa7e9acdec1cd7708351ddccf/ash/public/cpp/vector_icons/window_control_back.1x.icon [rename] https://crrev.com/464a588722dbc27fa7e9acdec1cd7708351ddccf/ash/public/cpp/vector_icons/window_control_back.icon [add] https://crrev.com/464a588722dbc27fa7e9acdec1cd7708351ddccf/ash/public/cpp/vector_icons/window_control_dezoom.1x.icon [add] https://crrev.com/464a588722dbc27fa7e9acdec1cd7708351ddccf/ash/public/cpp/vector_icons/window_control_dezoom.icon [add] https://crrev.com/464a588722dbc27fa7e9acdec1cd7708351ddccf/ash/public/cpp/vector_icons/window_control_menu.1x.icon [add] https://crrev.com/464a588722dbc27fa7e9acdec1cd7708351ddccf/ash/public/cpp/vector_icons/window_control_menu.icon [add] https://crrev.com/464a588722dbc27fa7e9acdec1cd7708351ddccf/ash/public/cpp/vector_icons/window_control_zoom.1x.icon [add] https://crrev.com/464a588722dbc27fa7e9acdec1cd7708351ddccf/ash/public/cpp/vector_icons/window_control_zoom.icon [modify] https://crrev.com/464a588722dbc27fa7e9acdec1cd7708351ddccf/ash/resources/vector_icons/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3105493765cce82b3d7df21253acd5503f43cf1 commit c3105493765cce82b3d7df21253acd5503f43cf1 Author: Mitsuru Oshima <oshima@chromium.org> Date: Mon Mar 26 18:22:30 2018 Introduce CaptionButtonModel to control the state of buttons on frame. CustomFrameViewAsh uses this mmode to turn on/off, enable/disable buttons on caption. Close button is always on for now. I'll have to investigate if this has to be enabled for ARC++ apps. BUG= 822960 , b/33693796 TEST=Covered by unit tests. Change-Id: I67fe2278b255ecd81e800209c52d51f9b4a3eb78 Reviewed-on: https://chromium-review.googlesource.com/975422 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#545842} [add] https://crrev.com/c3105493765cce82b3d7df21253acd5503f43cf1/ash/frame/caption_buttons/caption_button_model.h [modify] https://crrev.com/c3105493765cce82b3d7df21253acd5503f43cf1/ash/frame/caption_buttons/frame_back_button.cc [modify] https://crrev.com/c3105493765cce82b3d7df21253acd5503f43cf1/ash/frame/caption_buttons/frame_caption_button_container_view.cc [modify] https://crrev.com/c3105493765cce82b3d7df21253acd5503f43cf1/ash/frame/caption_buttons/frame_caption_button_container_view.h [modify] https://crrev.com/c3105493765cce82b3d7df21253acd5503f43cf1/ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc [modify] https://crrev.com/c3105493765cce82b3d7df21253acd5503f43cf1/ash/frame/custom_frame_view_ash.cc [modify] https://crrev.com/c3105493765cce82b3d7df21253acd5503f43cf1/ash/frame/custom_frame_view_ash.h [modify] https://crrev.com/c3105493765cce82b3d7df21253acd5503f43cf1/ash/frame/custom_frame_view_ash_unittest.cc [modify] https://crrev.com/c3105493765cce82b3d7df21253acd5503f43cf1/ash/frame/default_frame_header.cc [modify] https://crrev.com/c3105493765cce82b3d7df21253acd5503f43cf1/ash/frame/default_frame_header.h [modify] https://crrev.com/c3105493765cce82b3d7df21253acd5503f43cf1/ash/frame/detached_title_area_renderer.cc [modify] https://crrev.com/c3105493765cce82b3d7df21253acd5503f43cf1/ash/frame/header_view.cc [modify] https://crrev.com/c3105493765cce82b3d7df21253acd5503f43cf1/ash/frame/header_view.h [modify] https://crrev.com/c3105493765cce82b3d7df21253acd5503f43cf1/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c25dbbd2c0939d6a83d5fc306f3df7a349725f9b commit c25dbbd2c0939d6a83d5fc306f3df7a349725f9b Author: Mitsuru Oshima <oshima@chromium.org> Date: Tue Mar 27 03:45:37 2018 Add menu/zoom button BUG= 822960 TEST=covered by unittets Change-Id: Ia6c7f3c9a54b4059f85b049ecaa3f8a0b0c30e30 Reviewed-on: https://chromium-review.googlesource.com/977023 Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#545998} [modify] https://crrev.com/c25dbbd2c0939d6a83d5fc306f3df7a349725f9b/ash/frame/caption_buttons/caption_button_model.h [modify] https://crrev.com/c25dbbd2c0939d6a83d5fc306f3df7a349725f9b/ash/frame/caption_buttons/caption_button_types.h [modify] https://crrev.com/c25dbbd2c0939d6a83d5fc306f3df7a349725f9b/ash/frame/caption_buttons/frame_caption_button_container_view.cc [modify] https://crrev.com/c25dbbd2c0939d6a83d5fc306f3df7a349725f9b/ash/frame/caption_buttons/frame_caption_button_container_view.h [modify] https://crrev.com/c25dbbd2c0939d6a83d5fc306f3df7a349725f9b/ash/frame/caption_buttons/frame_size_button.cc [modify] https://crrev.com/c25dbbd2c0939d6a83d5fc306f3df7a349725f9b/ash/frame/custom_frame_view_ash_unittest.cc [modify] https://crrev.com/c25dbbd2c0939d6a83d5fc306f3df7a349725f9b/ash/frame/default_frame_header.cc [modify] https://crrev.com/c25dbbd2c0939d6a83d5fc306f3df7a349725f9b/ui/strings/ui_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/225299cde731875aa023a57e3bc15cc244870f6a commit 225299cde731875aa023a57e3bc15cc244870f6a Author: Mitsuru Oshima <oshima@chromium.org> Date: Tue Apr 03 16:36:09 2018 Add copyright to icon files, sort BUILD.gn BUG= 822960 TEST=None Change-Id: I63cb34bab20ba4801bed00ffd997063e6e45ef1e Reviewed-on: https://chromium-review.googlesource.com/981909 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#547731} [modify] https://crrev.com/225299cde731875aa023a57e3bc15cc244870f6a/ash/frame/custom_frame_view_ash_unittest.cc [modify] https://crrev.com/225299cde731875aa023a57e3bc15cc244870f6a/ash/frame/default_frame_header.cc [modify] https://crrev.com/225299cde731875aa023a57e3bc15cc244870f6a/ash/public/cpp/vector_icons/BUILD.gn [modify] https://crrev.com/225299cde731875aa023a57e3bc15cc244870f6a/ash/resources/vector_icons/BUILD.gn [rename] https://crrev.com/225299cde731875aa023a57e3bc15cc244870f6a/ash/resources/vector_icons/window_control_back.icon [rename] https://crrev.com/225299cde731875aa023a57e3bc15cc244870f6a/ash/resources/vector_icons/window_control_dezoom.icon [rename] https://crrev.com/225299cde731875aa023a57e3bc15cc244870f6a/ash/resources/vector_icons/window_control_menu.icon [rename] https://crrev.com/225299cde731875aa023a57e3bc15cc244870f6a/ash/resources/vector_icons/window_control_zoom.icon
https://chromium-review.googlesource.com/c/chromium/src/+/992355
Comment 1 by osh...@chromium.org
, Mar 16 2018