New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822954 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task
Launch-Accessibility: NA
Launch-Exp-Leadership: NA
Launch-Leadership: NA
Launch-Legal: NA
Launch-M-Target: 67-Dev , 68-Dev , 68-Beta , 68-Stable-Exp , 68-Stable , 69-Dev , 69-Beta , 69-Stable-Exp , 69-Stable , 70-Dev , 70-Beta , 70-Stable-Exp , 70-Stable , 71-Dev , 71-Beta
Launch-Privacy: NA
Launch-Security: NA
Launch-Test: NA
Launch-UI: NA
Rollout-Type: Finch



Sign in to add a comment

Stop more task queues in Background on Android

Project Member Reported by panicker@chromium.org, Mar 16 2018

Issue description

Technical feature description:

Eng owner: panicker@chromium.org

Design doc (send to chrome-design-docs@):
https://docs.google.com/document/d/10D2uvOVxBZ2YhcwtK1XOb6CClminPpqAeS82KOVT7hk/edit#

Metrics: TBD

 
Cc: skare@chromium.org
Finch ambassador: skare@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56c99a25b185f901a1abb7e912bc71e0705a318a

commit 56c99a25b185f901a1abb7e912bc71e0705a318a
Author: Shubhie Panicker <panicker@chromium.org>
Date: Wed Mar 21 00:22:28 2018

Add flag for finch to stop more task queues.

A field trial param will be used to specifically stop
deferrable vs. pauseable task queues.

Doc: https://docs.google.com/document/d/10D2uvOVxBZ2YhcwtK1XOb6CClminPpqAeS82KOVT7hk/edit#

BUG: 822954

Change-Id: Ia41e970f22b733150393ecc8ae09a3df7f2295ca
Reviewed-on: https://chromium-review.googlesource.com/967442
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544601}
[modify] https://crrev.com/56c99a25b185f901a1abb7e912bc71e0705a318a/chrome/browser/about_flags.cc
[modify] https://crrev.com/56c99a25b185f901a1abb7e912bc71e0705a318a/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/56c99a25b185f901a1abb7e912bc71e0705a318a/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/56c99a25b185f901a1abb7e912bc71e0705a318a/content/child/runtime_features.cc
[modify] https://crrev.com/56c99a25b185f901a1abb7e912bc71e0705a318a/content/public/common/content_features.cc
[modify] https://crrev.com/56c99a25b185f901a1abb7e912bc71e0705a318a/content/public/common/content_features.h
[modify] https://crrev.com/56c99a25b185f901a1abb7e912bc71e0705a318a/tools/metrics/histograms/enums.xml

Comment 3 by amin...@google.com, May 16 2018

Labels: Launch-Exp-Leadership-NA
Updating launch bugs to convert to new launch process in go/newChromeFeature.  Automatically setting Launch-Exp-Leadership-NA since this appears to be a legacy technical / simple launch (all existing cross-functional bits are set to NA).  Note that in the new process, no review / approval for technical / simple launches is required (though please be sure you are confident there is no cross-functional impact here).  Contact amineer@ with any questions or concerns.

Comment 4 by amin...@google.com, May 16 2018

Labels: Launch-Leadership-NA
Updating launch bugs to convert to new launch process in go/newChromeFeature.  Automatically setting Launch-Leadership-NA since this appears to be a legacy technical / simple launch (all existing cross-functional bits are set to NA).  Note that in the new process, no review / approval for technical / simple launches is required (though please be sure you are confident there is no cross-functional impact here).  Contact amineer@ with any questions or concerns.
Cc: shaseley@google.com
Labels: Launch-M-Target-68-Beta Launch-M-Target-69-Beta Rollout-Type-Finch
Cc: -shaseley@google.com panicker@chromium.org
Owner: shaseley@google.com
Cc: haraken@chromium.org altimin@chromium.org
Metrics summary from Canary/Dev:

We're seeing significant decreases (expected) in total task duration (CPU) for tasks in pausable and deferrable queues. There is a correlated significant decrease in total IPC task duration. Loading and responsiveness metrics, however, do not show any statistically significant movement.
Labels: Launch-M-Target-68-Dev Launch-M-Target-69-Dev Launch-M-Target-70-Dev Launch-M-Target-70-Beta Launch-M-Target-71-Dev Launch-M-Target-71-Beta
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee0f7bb8217a7d3ebb41299ca9f2707906e0cd96

commit ee0f7bb8217a7d3ebb41299ca9f2707906e0cd96
Author: Scott Haseley <shaseley@google.com>
Date: Tue Jul 24 01:19:32 2018

Enable StopNonTimersInBackground experiment for field trial testing

Bug: 822954
Change-Id: I8668f4003bff3fa47e1b542884f81cf1e13bffad
Reviewed-on: https://chromium-review.googlesource.com/1147505
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Scott Haseley <shaseley@google.com>
Cr-Commit-Position: refs/heads/master@{#577392}
[modify] https://crrev.com/ee0f7bb8217a7d3ebb41299ca9f2707906e0cd96/testing/variations/fieldtrial_testing_config.json

Cc: amineer@chromium.org
amineer@, why haven't the approved bits been auto-flipped on this launch bug?  What's missing?
Owner: panicker@chromium.org
Labels: Launch-M-Target-68-Stable-Exp Launch-M-Target-68-Stable Launch-M-Target-69-Stable-Exp Launch-M-Target-69-Stable Launch-M-Target-70-Stable-Exp Launch-M-Target-70-Stable
I'd like to go to ramp up to stable 100% and ship this.
Link to I2S: https://groups.google.com/a/chromium.org/d/msg/blink-dev/NKtuFxLsKgo/brL3bfS5CAAJ 

Metrics Summary: major (40% to 72%) CPU reduction (and battery saving), and no regressions in regression-metrics.
Deatils here:
https://docs.google.com/document/d/10D2uvOVxBZ2YhcwtK1XOb6CClminPpqAeS82KOVT7hk/edit#heading=h.t2mfza80xa3v

What's the process for getting the launch-M-approved bit?

Owner: amineer@chromium.org
assigning to amineer as there was an issue with auto-flipping of the bits.
Cc: -panicker@chromium.org josa...@chromium.org
Owner: panicker@chromium.org
I've left the Chrome team, CC'ing josafat@ as my replacement.  That said this looks to have been a technical feature given all cross-functional bits are NA.  The script doesn't auto approve these as they're no longer considered launches in the new world.  If this truly is not a feature per go/newChromeLaunch then you can change this to Type=Task and launch whenever you're ready.
Cc: -amineer@chromium.org
No longer on the Chrome team, e-mail me @google.com if any attention still required from me here, otherwise good luck!
Labels: -Type-Launch Type-Task
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60bd4b09acaa1e4e7ea50ea35de36a63587c8025

commit 60bd4b09acaa1e4e7ea50ea35de36a63587c8025
Author: Shubhie Panicker <panicker@chromium.org>
Date: Wed Sep 26 00:02:15 2018

Enable StopNonTimersInBackground by default on Android.

Bug: 822954
Change-Id: Ife5a6460c0215fa188e3734fa781ecfb994e94b9
Reviewed-on: https://chromium-review.googlesource.com/1241994
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594148}
[modify] https://crrev.com/60bd4b09acaa1e4e7ea50ea35de36a63587c8025/third_party/blink/common/features.cc
[modify] https://crrev.com/60bd4b09acaa1e4e7ea50ea35de36a63587c8025/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc

Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment