Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of karandeepb@google.com BackgroundFetchBrowserTest.OfflineItemCollection_SingleFileMetadata is flaky See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BackgroundFetchBrowserTest.OfflineItemCollection_SingleFileMetadata
This was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/955844. (2 days ago). Will see if it can be reverted cleanly, else will disable the test.
Correction this landed 4 days ago.
Will just disable the test.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c002f468c65354e4f80aeae7bb02fcb4181e914a commit c002f468c65354e4f80aeae7bb02fcb4181e914a Author: Karan Bhatia <karandeepb@chromium.org> Date: Fri Mar 16 23:29:09 2018 Disable flaky BackgroundFetchBrowserTest.OfflineItemCollection_SingleFileMetadata. BUG=822944 TBR=peter@chromium.org Change-Id: Ibf81ac125ecd066e6c90e1c21788f3938d8380fc Reviewed-on: https://chromium-review.googlesource.com/967378 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543867} [modify] https://crrev.com/c002f468c65354e4f80aeae7bb02fcb4181e914a/chrome/browser/background_fetch/background_fetch_browsertest.cc
The following revision fixes this bug: https://chromium.googlesource.com/chromium/src.git/+/b1a8b203ae9c854f97d0750591a118f52e6f84a4 commit b1a8b203ae9c854f97d0750591a118f52e6f84a4 Author: Mugdha Lakhani <nator@chromium.org> Date: Mon Mar 26 16:03:27 2018 Pass around BackgroundFetch options as mojom type. CL https://chromium-review.googlesource.com/c/chromium/src/+/956183 caused a few tests to be flaky, which was due to the garbage collector getting rid of BackgroundFetchOptions from under us. This change creates a copy of background fetch options early on, converting them from blink::BackgroundFetchOptions to mojom::blink::BackgroundFetchRegistrationPtr. This copy is not going to be deleted by the GC, hence ensuring accurate data later on in the processing of the fetch. Bug: 822276 Change-Id: Iaab780b18182372cf607b57eb15815c852d4595a Reviewed-on: https://chromium-review.googlesource.com/977909 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#545805} [modify] https://crrev.com/b1a8b203ae9c854f97d0750591a118f52e6f84a4/chrome/browser/background_fetch/background_fetch_browsertest.cc [modify] https://crrev.com/b1a8b203ae9c854f97d0750591a118f52e6f84a4/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp [modify] https://crrev.com/b1a8b203ae9c854f97d0750591a118f52e6f84a4/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.h [modify] https://crrev.com/b1a8b203ae9c854f97d0750591a118f52e6f84a4/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchIconLoader.cpp [modify] https://crrev.com/b1a8b203ae9c854f97d0750591a118f52e6f84a4/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchIconLoader.h [modify] https://crrev.com/b1a8b203ae9c854f97d0750591a118f52e6f84a4/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp [modify] https://crrev.com/b1a8b203ae9c854f97d0750591a118f52e6f84a4/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h
Comment 1 by karandeepb@chromium.org
, Mar 16 2018Status: Assigned (was: Available)