New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 822922 link

Starred by 2 users
Status: Fixed
Owner:
█ jcivelli@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

SafeMediaMetadataParser should be simplified

Project Member Reported by jcivelli@chromium.org, Mar 16 2018 
SafeMediaMetadataParser is still doing thread hops between the UI and IO threads when it does not need to anymore.
It used to because it was using the UtilityMojoClient that had to be accessed on the IO thread. Now that it's been ported to a Mojo service, every thing can happen on the UI thread.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7064311c691705e683becec8bcc5523381708a86

commit 7064311c691705e683becec8bcc5523381708a86
Author: Jay Civelli <jcivelli@google.com>
Date: Sat Mar 17 19:52:08 2018

Simplify SafeMediaMetadataParser

Now that it uses a Mojo service, SafeMediaMetadataParser can be
simplified as it does not require thread hops. Which also means it does
not need to be ref counted anymore.
Also changed Bind calls to BindOnce where appropriate.

Bug:  822922 
Change-Id: Id684d9e7bb52f11f19d992f0d5dcb80c8d7e4770
Reviewed-on: https://chromium-review.googlesource.com/967364
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543948}
[modify] https://crrev.com/7064311c691705e683becec8bcc5523381708a86/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
[modify] https://crrev.com/7064311c691705e683becec8bcc5523381708a86/chrome/browser/extensions/api/media_galleries/media_galleries_api.h
[modify] https://crrev.com/7064311c691705e683becec8bcc5523381708a86/chrome/services/media_gallery_util/public/cpp/safe_media_metadata_parser.cc
[modify] https://crrev.com/7064311c691705e683becec8bcc5523381708a86/chrome/services/media_gallery_util/public/cpp/safe_media_metadata_parser.h

Comment 2 by jcivelli@chromium.org, Mar 19 2018

Status: Fixed (was: Started)
►

Sign in to add a comment