New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822909 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

JavaScript cpu profiler fails to load a profile

Project Member Reported by alph@chromium.org, Mar 16 2018

Issue description

That happens when the last sample in the profile is GC.

 

Comment 1 by alph@chromium.org, Mar 16 2018

Cc: evanm@google.com
Components: Platform>DevTools>JavaScript
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56d8b2790cfb3e3c2f3fcf4dd326133d90bc2788

commit 56d8b2790cfb3e3c2f3fcf4dd326133d90bc2788
Author: Alexei Filippov <alph@chromium.org>
Date: Sat Mar 17 00:20:20 2018

DevTools: Fix loading CPU profiles having last GC sample

When the last sample in a profile happen to be a (garbage collector), the
forEachFrame function failed to close last opened stack frames.

BUG= 822909 

Change-Id: I5165491e1aa1b92466aec339aa848186c89eb9f9
Reviewed-on: https://chromium-review.googlesource.com/967272
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543880}
[add] https://crrev.com/56d8b2790cfb3e3c2f3fcf4dd326133d90bc2788/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-parsing-expected.txt
[add] https://crrev.com/56d8b2790cfb3e3c2f3fcf4dd326133d90bc2788/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/cpu-profiler-parsing.js
[modify] https://crrev.com/56d8b2790cfb3e3c2f3fcf4dd326133d90bc2788/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-streamed-cpu-profile-expected.txt
[modify] https://crrev.com/56d8b2790cfb3e3c2f3fcf4dd326133d90bc2788/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/trace-event-self-time-expected.txt
[modify] https://crrev.com/56d8b2790cfb3e3c2f3fcf4dd326133d90bc2788/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js

Comment 3 by alph@chromium.org, Mar 17 2018

Status: Fixed (was: Started)

Sign in to add a comment