New issue
Advanced search Search tips

Issue 822902 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Broadcast component installation signal

Project Member Reported by xiaochu@chromium.org, Mar 16 2018

Issue description

Problem: modemfwd requests component installation (over dbus) when component updater is not running or internet isn't available. Rather than waiting and retrying, modemfwd prefers to be notified.

Proposal:
Send a dbus signal after a component is installed. 
modemfwd could call API to mount the component upon being notified.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/c873de4b9021e002a2a742aee91fbc612c2445d6

commit c873de4b9021e002a2a742aee91fbc612c2445d6
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Mon Mar 26 21:41:38 2018

chrome ComponentInstalled dbus signal constant

Adding a constant for ComponentInstalled dbus signal. This signal is
emitted by chrome when a component is installed/updated and ready to be
mounted (by imageloader).

BUG= chromium:822902 
TEST=None

Change-Id: Ib353dcfa3faed2866b2c98bae05948d460211f7c
Reviewed-on: https://chromium-review.googlesource.com/978869
Commit-Ready: Xiaochu Liu <xiaochu@chromium.org>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/c873de4b9021e002a2a742aee91fbc612c2445d6/dbus/service_constants.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2e1a9ae09f90e23e87156ac3143c3e2a562493e

commit e2e1a9ae09f90e23e87156ac3143c3e2a562493e
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Mon Apr 30 23:25:45 2018

component_updater: broadcast install signal to platform

On a successful install/update, component_updater sends a dbus signal to
platform. This allows compnoent consumers to be notified instead of
retrying calling the Load API.

Include dbus in chrome/browser/DEPS

BUG= chromium:822902 
TEST=sudo -u root dbus-monitor --system  "type='signal',sender='org.chromium.ComponentUpdaterService',interface='org.chromium.ComponentUpdaterService'"

Change-Id: Ie913658329e6eb0cf0deb030fc772ec03fdbd8ea
Reviewed-on: https://chromium-review.googlesource.com/984600
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554921}
[modify] https://crrev.com/e2e1a9ae09f90e23e87156ac3143c3e2a562493e/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/e2e1a9ae09f90e23e87156ac3143c3e2a562493e/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[delete] https://crrev.com/a02ed73cb556401b390bc22ef71e86ca31f73e1b/chrome/browser/chromeos/dbus/chrome_component_updater_service_provider_delegate.cc
[delete] https://crrev.com/a02ed73cb556401b390bc22ef71e86ca31f73e1b/chrome/browser/chromeos/dbus/chrome_component_updater_service_provider_delegate.h
[add] https://crrev.com/e2e1a9ae09f90e23e87156ac3143c3e2a562493e/chrome/browser/chromeos/dbus/component_updater_service_provider.cc
[rename] https://crrev.com/e2e1a9ae09f90e23e87156ac3143c3e2a562493e/chrome/browser/chromeos/dbus/component_updater_service_provider.h
[rename] https://crrev.com/e2e1a9ae09f90e23e87156ac3143c3e2a562493e/chrome/browser/chromeos/dbus/org.chromium.ComponentUpdaterService.conf
[modify] https://crrev.com/e2e1a9ae09f90e23e87156ac3143c3e2a562493e/chrome/browser/component_updater/cros_component_installer.cc
[modify] https://crrev.com/e2e1a9ae09f90e23e87156ac3143c3e2a562493e/chrome/browser/component_updater/cros_component_installer.h
[modify] https://crrev.com/e2e1a9ae09f90e23e87156ac3143c3e2a562493e/chromeos/BUILD.gn
[delete] https://crrev.com/a02ed73cb556401b390bc22ef71e86ca31f73e1b/chromeos/dbus/services/component_updater_service_provider.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment