Stack overflow while running ConstrainedWindowViewTest.ClosesOnEscape and a few others.
Stack attached.
 

Deleted: Stack.txt 18.5 KB

Stack.txt 18.5 KB View Download

Bad Widget Delegate while calling CanActivate(). See Stack.
 

Deleted: Stack.txt 18.5 KB

Stack.txt 18.5 KB View Download

ConstrainedWindowViewTest.ClosesOnEscape
Bad Widget Delegate while calling CanActivate(). See Stack.

This is caused by the dialog failing to consistently dismiss during the test.

IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, ClosesOnEscape) {
  std::unique_ptr<TestDialog> dialog =
      ShowModalDialog(browser()->tab_strip_model()->GetActiveWebContents());
  EXPECT_TRUE(dialog->GetWidget()->IsVisible());
  EXPECT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_ESCAPE,
                                              false, false, false, false));
  content::RunAllPendingInMessageLoop();
  EXPECT_EQ(NULL, dialog->GetWidget()); <--- Fails, and after this the TestDialog is destroyed, resulting in a bad widget delegate laterr.
}
 

Deleted: Stack.txt 18.5 KB

Stack.txt 18.5 KB View Download

Affected Tests:
ConstrainedWindowViewTest.ClosesOnEscape
ExtensionDialogUiTest.TabFocusLoop

Symptoms:
  Bad Widget Delegate while calling CanActivate(). See Stack.

  This is caused by the dialog failing to consistently dismiss during the test.

  IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, ClosesOnEscape) {
    std::unique_ptr<TestDialog> dialog =
        ShowModalDialog(browser()->tab_strip_model()->GetActiveWebContents());
    EXPECT_TRUE(dialog->GetWidget()->IsVisible());
    EXPECT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_ESCAPE,
                                                false, false, false, false));
    content::RunAllPendingInMessageLoop();
    EXPECT_EQ(NULL, dialog->GetWidget()); <--- Fails, and after this the TestDialog is destroyed, resulting in a bad widget delegate laterr.
  }

Waiting for a keypress that never arrives:
ExtensionDialogUiTest.TabFocusLoop
    ASSERT_TRUE(ui_controls::SendKeyPress(
                    browser()->window()->GetNativeWindow(),
                    ui::VKEY_TAB, false, true, false, false));
    ASSERT_TRUE(button3_focus_listener.WaitUntilSatisfied()); <- Never Returns