caption size button image is no correctly set involving tablet mode |
|||
Issue descriptionRepro steps: 1) Open a maximized Chrome window. 2) Minimize it by pressing the horizontal underscore icon at the upper right (next to the maximize icon). 3) Go into tablet mode. 4) Go out of tablet mode. 5) unminimize the chrome window. caption button should be `restore` button but it is `maximize` button. Issue is from #48 in issue 783310 .
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97524c138aa402ef7fcf06834c37173edde481fc commit 97524c138aa402ef7fcf06834c37173edde481fc Author: Qiang Xu <warx@google.com> Date: Thu Mar 22 17:37:54 2018 cros: do not update caption buttons on minimized window changes: Toggle tablet mode is set to update caption buttons to update size button visibility. In minimized state, frame is not maximized or fullscreen, thus the size button will be set to MAXIMIZE button not RESTORE button. This CL avoids such update when window is minimized. Bug: 822890 , 783310 Test: manual test and added test coverage Change-Id: Id35db6dcfbc79e6783caf8706fb83d25402f9c21 Reviewed-on: https://chromium-review.googlesource.com/967414 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#545133} [modify] https://crrev.com/97524c138aa402ef7fcf06834c37173edde481fc/ash/frame/caption_buttons/frame_caption_button.h [modify] https://crrev.com/97524c138aa402ef7fcf06834c37173edde481fc/ash/frame/default_frame_header.cc [modify] https://crrev.com/97524c138aa402ef7fcf06834c37173edde481fc/chrome/browser/ui/views/frame/browser_frame_header_ash.cc [modify] https://crrev.com/97524c138aa402ef7fcf06834c37173edde481fc/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h [modify] https://crrev.com/97524c138aa402ef7fcf06834c37173edde481fc/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
,
Mar 22 2018
,
Mar 23 2018
#1 this bug appears different than what I reported in #48; The expectation is that the window still is maximized after coming out of tablet mode, not as in #1 where it says "caption button should be `restore` button but it is `maximize` button.". Minimized window appears in wrong state after going into tablet mode: 1) Open a maximized Chrome window. 2) Minimize it by pressing the horizontal underscore icon at the upper right (next to the maximize icon). 3) Go into tablet mode. 4) Go out of tablet mode. 5) Alt-tab to view the window. Expected result: Window is still maximized Actual result: Window appears as if un-maximized (single square box at upper right), but if you try to maximize it doesn't work, instead it goes to the un-maximized state first, then if you maximize again it works
,
Mar 23 2018
Yeah, the description is different. But that is the bug we have. If you we have double square box after step (5), it makes all sense to click it to get un-maximized state first. Right?
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2eb960c8036afcd2b09eb768e9aff390eeb439f8 commit 2eb960c8036afcd2b09eb768e9aff390eeb439f8 Author: Qiang Xu <warx@google.com> Date: Mon Mar 26 16:40:05 2018 m66 merge: cros: do not update caption buttons on minimized window changes: Toggle tablet mode is set to update caption buttons to update size button visibility. In minimized state, frame is not maximized or fullscreen, thus the size button will be set to MAXIMIZE button not RESTORE button. This CL avoids such update when window is minimized. TBR=sky@chromium.org (cherry picked from commit 97524c138aa402ef7fcf06834c37173edde481fc) Bug: 822890 , 783310 Test: manual test and added test coverage Change-Id: Id35db6dcfbc79e6783caf8706fb83d25402f9c21 Reviewed-on: https://chromium-review.googlesource.com/967414 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Original-Commit-Position: refs/heads/master@{#545133} Reviewed-on: https://chromium-review.googlesource.com/980822 Reviewed-by: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/branch-heads/3359@{#431} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/2eb960c8036afcd2b09eb768e9aff390eeb439f8/ash/frame/caption_buttons/frame_caption_button.h [modify] https://crrev.com/2eb960c8036afcd2b09eb768e9aff390eeb439f8/ash/frame/default_frame_header.cc [modify] https://crrev.com/2eb960c8036afcd2b09eb768e9aff390eeb439f8/chrome/browser/ui/views/frame/browser_frame_header_ash.cc [modify] https://crrev.com/2eb960c8036afcd2b09eb768e9aff390eeb439f8/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h [modify] https://crrev.com/2eb960c8036afcd2b09eb768e9aff390eeb439f8/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by warx@chromium.org
, Mar 16 2018