New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822874 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Non-VR dialog displayed when asking for storage permission when they are disabled for Chrome.

Project Member Reported by dougman@chromium.org, Mar 16 2018

Issue description

Chrome Version: 67.0.3372.0
OS: Android 8.1.0 on Pixel 2

What steps will reproduce the problem?
(1) Ensure that the Storage permission is Off for Chrome.
(2) Go to https://permission.site
(3) Enter VR
(4) Click "Auto Download" button.

What is the expected result?
Nothing should happen.  The Permission is disabled at the Chrome level.  Other permissions do nothing when disabled at the Chrome level.

What happens instead?
Non-VR dialog is displayed:  "Chrome needs storage access to download files.

 
Screenshot_20180316-125430.png
310 KB View Download
Screenshot_20180316-125436.png
83.8 KB View Download
Cc: dbbrooks@chromium.org

Comment 2 by ericde@google.com, Mar 23 2018

Cc: asimjour@chromium.org ymalik@chromium.org
Labels: -Pri-3 M-67 Hotlist-VRB-MVP Pri-1
Status: Available (was: Untriaged)

Comment 3 by bshe@chromium.org, Apr 9 2018

Owner: bshe@chromium.org
Status: Started (was: Available)
It is a recent regression. To handle it correctly in VR is tracked here:
https://bugs.chromium.org/p/chromium/issues/detail?id=642934


Project Member

Comment 4 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5af533ad08905a1d67c03e9cde9e5bc505b8f5e

commit f5af533ad08905a1d67c03e9cde9e5bc505b8f5e
Author: Biao She <bshe@chromium.org>
Date: Tue Apr 10 19:16:41 2018

Suppress Android storage permission request while in VR

Also, notify UI thread that storage permission request failed if
we suppressed storage permission UI while in VR.

Bug:  822874 
Change-Id: I3f1bb2339f31c47a8a28c03107a21796ff0adc7e
Reviewed-on: https://chromium-review.googlesource.com/1005277
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549608}
[modify] https://crrev.com/f5af533ad08905a1d67c03e9cde9e5bc505b8f5e/chrome/browser/android/download/download_controller.cc

Comment 5 by bshe@chromium.org, Apr 11 2018

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Confirmed on 67.0.3396.16

Sign in to add a comment