New issue
Advanced search Search tips

Issue 822867 link

Starred by 1 user
Status: Fixed
Owner:
pmonette@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

ProblematicProgramsUpdater is doing unnecessary work in HasCachedPrograms

Project Member Reported by pmonette@chromium.org, Mar 16 2018 
HasCachedPrograms does all the same work as GetCachedPrograms and then check if the vector is empty. This can be simplified to return immediately when a valid program in the cache is found.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6dc176656aeec508d4cbcbf6b358b931910fa26

commit b6dc176656aeec508d4cbcbf6b358b931910fa26
Author: Patrick Monette <pmonette@chromium.org>
Date: Mon Mar 26 16:17:10 2018

Optimize ProblematicProgramsUpdater::HasCachedPrograms()

This function now returns after the first valid program found in the
cache instead of building a vector containing all the programs.

Bug:  822867 
Change-Id: I9757ac6f81ac4ad4d588461b95af15865e25d863
Reviewed-on: https://chromium-review.googlesource.com/967149
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545810}
[modify] https://crrev.com/b6dc176656aeec508d4cbcbf6b358b931910fa26/chrome/browser/conflicts/problematic_programs_updater_win.cc

Comment 2 by pmonette@chromium.org, Mar 26 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment