New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822857 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Task


Sign in to add a comment

Implement SkiaRenderer filters.

Project Member Reported by weiliangc@chromium.org, Mar 16 2018

Issue description

This include filter, background filter, and color filters.
 

Comment 1 by xing...@intel.com, Mar 19 2018

Blockedon: 823182

Comment 2 by xing...@intel.com, Mar 21 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f933f0ca2e9a1e25791aee58febaea0cffb521b

commit 8f933f0ca2e9a1e25791aee58febaea0cffb521b
Author: Xu Xing <xing.xu@intel.com>
Date: Thu Mar 22 00:14:07 2018

viz: Support filter in SkiaRenderer

TODOs:
Support flip_texture. crbug.com/822859.
Support SkColorFilter. crbug.com/823182

BUG=822857

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ic442e5d544929cca8f43c911dea231e51aeaaaed
Reviewed-on: https://chromium-review.googlesource.com/912326
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#544915}
[modify] https://crrev.com/8f933f0ca2e9a1e25791aee58febaea0cffb521b/cc/base/math_util.cc
[modify] https://crrev.com/8f933f0ca2e9a1e25791aee58febaea0cffb521b/cc/base/math_util.h
[modify] https://crrev.com/8f933f0ca2e9a1e25791aee58febaea0cffb521b/cc/paint/paint_filter.h
[modify] https://crrev.com/8f933f0ca2e9a1e25791aee58febaea0cffb521b/components/viz/common/BUILD.gn
[modify] https://crrev.com/8f933f0ca2e9a1e25791aee58febaea0cffb521b/components/viz/common/DEPS
[add] https://crrev.com/8f933f0ca2e9a1e25791aee58febaea0cffb521b/components/viz/common/skia_helper.cc
[add] https://crrev.com/8f933f0ca2e9a1e25791aee58febaea0cffb521b/components/viz/common/skia_helper.h
[modify] https://crrev.com/8f933f0ca2e9a1e25791aee58febaea0cffb521b/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/8f933f0ca2e9a1e25791aee58febaea0cffb521b/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/8f933f0ca2e9a1e25791aee58febaea0cffb521b/components/viz/service/display/skia_renderer.h

Comment 4 by xing...@intel.com, Apr 4 2018

Blockedon: 828728

Comment 5 by xing...@intel.com, Apr 11 2018

Blockedon: 831485
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a13c5f52e732af62438d9ab9588fb9cc00a6fb2b

commit a13c5f52e732af62438d9ab9588fb9cc00a6fb2b
Author: Xu Xing <xing.xu@intel.com>
Date: Fri Apr 20 04:30:56 2018

viz: Support background filter in SkiaRenderer

This passes all current css/filters layout tests and skia renderer
backdrop filter pixel test.

Remove the TODO(skaslev): The software renderer does not support filters yet.

BUG=822857, 828728 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I6f96259249612e8655c953bdd6a534ae9f5c6acc
Reviewed-on: https://chromium-review.googlesource.com/985635
Commit-Queue: Xing Xu <xing.xu@intel.com>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552260}
[modify] https://crrev.com/a13c5f52e732af62438d9ab9588fb9cc00a6fb2b/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/a13c5f52e732af62438d9ab9588fb9cc00a6fb2b/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/a13c5f52e732af62438d9ab9588fb9cc00a6fb2b/components/viz/service/display/skia_renderer.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/770f56faf8cd4a892c2d3d516434c62e40527d4a

commit 770f56faf8cd4a892c2d3d516434c62e40527d4a
Author: Peng Huang <penghuang@chromium.org>
Date: Wed Jun 06 19:06:09 2018

Use SkCavnas::saveLayer() to implement backdrop effect.

The original implementation needs readback from the FBO, it doesn't work
with SkDDL, because the FBO will not have the content until the recorded
SkDDL is played back on the Gpu thread. This CL uses SkCanvas::saveLayer()
to implement the backdrop effect. It doesn't need read the FBO.


Test: Passed layeout tests css3/filters/*.html with and without SkDDL
Bug: 822857
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I213fdff5f73c13af34a0295c666b80353642de96
Reviewed-on: https://chromium-review.googlesource.com/1073664
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564993}
[modify] https://crrev.com/770f56faf8cd4a892c2d3d516434c62e40527d4a/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/770f56faf8cd4a892c2d3d516434c62e40527d4a/components/viz/service/display/skia_renderer.h

Sign in to add a comment