New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 822853 link

Starred by 1 user
Status: Fixed
Owner:
dnicoara@chromium.org
Closed: Jul 24
Cc:
█ alexst@chromium.org
rjkroege@chromium.org
dcasta...@chromium.org
█ hoegsberg@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----



Sign in to add a comment

Remove overlay support on the Ozone DRM legacy path

Project Member Reported by dnicoara@chromium.org, Mar 16 2018 
Overlay support was only added on the legacy DRM path as a way to bring up Chrome overlay while the atomic DRM path wasn't ready.

It is not used in production anywhere and is adding code complexity.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81e3eb74fedc3147acb0d5dcfffb192b6973bf51

commit 81e3eb74fedc3147acb0d5dcfffb192b6973bf51
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Tue Jul 24 18:16:15 2018

[Ozone-DRM] Remove support for overlays on DRM legacy

DRM legacy is never used with overlays due to a lack of synchronization
during page flip. Remove the complexity behing trying to page flip
overlays on legacy. Also move tests that deal with overlays to use
atomic configuration.

BUG= 822853 
TEST=Ran unittests
TEST=Ran chrome on Samus to validate legacy path still works
TEST=Ran chrome on Eve to ensure atomic path hasn't regressed

Change-Id: Ibc82aafd367c8d12106d3a0e835a3b4b38e0161a
Reviewed-on: https://chromium-review.googlesource.com/1120692
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577610}
[modify] https://crrev.com/81e3eb74fedc3147acb0d5dcfffb192b6973bf51/ui/ozone/platform/drm/gpu/drm_overlay_validator_unittest.cc
[modify] https://crrev.com/81e3eb74fedc3147acb0d5dcfffb192b6973bf51/ui/ozone/platform/drm/gpu/hardware_display_controller_unittest.cc
[modify] https://crrev.com/81e3eb74fedc3147acb0d5dcfffb192b6973bf51/ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc
[modify] https://crrev.com/81e3eb74fedc3147acb0d5dcfffb192b6973bf51/ui/ozone/platform/drm/gpu/hardware_display_plane_manager.h
[modify] https://crrev.com/81e3eb74fedc3147acb0d5dcfffb192b6973bf51/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc
[modify] https://crrev.com/81e3eb74fedc3147acb0d5dcfffb192b6973bf51/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.h
[modify] https://crrev.com/81e3eb74fedc3147acb0d5dcfffb192b6973bf51/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc
[modify] https://crrev.com/81e3eb74fedc3147acb0d5dcfffb192b6973bf51/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.h
[modify] https://crrev.com/81e3eb74fedc3147acb0d5dcfffb192b6973bf51/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_unittest.cc
[modify] https://crrev.com/81e3eb74fedc3147acb0d5dcfffb192b6973bf51/ui/ozone/platform/drm/gpu/mock_drm_device.cc
[modify] https://crrev.com/81e3eb74fedc3147acb0d5dcfffb192b6973bf51/ui/ozone/platform/drm/gpu/mock_drm_device.h

Comment 2 by dnicoara@chromium.org, Jul 24

Status: Fixed (was: Assigned)
►

Sign in to add a comment