New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822844 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Add uma to log space status when installing WebAPK

Project Member Reported by ranj@chromium.org, Mar 16 2018

Issue description

Previously we developed features for webapk installation on low space devices, but we don't have an accurate UMA to track it.
 

Comment 1 by ranj@chromium.org, Mar 16 2018

Status: Fixed (was: Untriaged)
commit ebf30557b76f27757dbdaa1a03e7104fd7ce29c5
Author: Ran Ji <ranj@chromium.org>

Add uma to log space status when installing WebAPK

Bug:  822844 
Change-Id: Ibae84f3215ae29e2154df538f4ff7e86f72118b5
Reviewed-on: https://chromium-review.googlesource.com/959750
Commit-Queue: Ran Ji <ranj@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543003}

Comment 2 by ranj@chromium.org, Mar 16 2018

Labels: -Pri-3 Merge-Request-66 OS-Android Pri-2
+Merge-Request-66

Affected OS: Android

This cl adds UMAs to log if we have enough space when installing WebAPK.
It should be safe as the only code change is calling UMA_HISTOGRAM_ENUMERATION
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 16 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by cmasso@google.com, Mar 19 2018

Labels: -Hotlist-Merge-Review -Merge-Review-66 Merge-Approved-66
Reminder to please merge to M66 3359 branch soon.
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 23 2018

Cc: cmasso@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Mar 27 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by ranj@chromium.org, Mar 27 2018

Labels: -Merge-Approved-66

Sign in to add a comment