The documentation has already been updated: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/memory/debugging_memory_issues.md#Taking-a-Heap-Dump And memlog now has feature parity, with some additional polish coming down the line: https://bugs.chromium.org/p/chromium/issues/detail?id=809203
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/17fc85e9cd7d537fbdc81654b2a3b8745a99ce50 commit 17fc85e9cd7d537fbdc81654b2a3b8745a99ce50 Author: erikchen <erikchen@chromium.org> Date: Mon Mar 19 20:05:47 2018 Replace --enable-heap-profiling with --memlog equivalent. The latter is the supported heap profiling mode. The former is deprecated. Bug: chromium:822843 Change-Id: I00588ef369aa01970ad4f8bc7da3adb82621ac7a Reviewed-on: https://chromium-review.googlesource.com/967063 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> [modify] https://crrev.com/17fc85e9cd7d537fbdc81654b2a3b8745a99ce50/tracing/bin/memory_infra_remote_dump [modify] https://crrev.com/17fc85e9cd7d537fbdc81654b2a3b8745a99ce50/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6aea1cac122502499713bfc182d0454d0f325fa9 commit 6aea1cac122502499713bfc182d0454d0f325fa9 Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Mar 23 14:48:06 2018 Roll src/third_party/catapult/ 734f737c6..c4e9b1332 (14 commits) https://chromium.googlesource.com/catapult.git/+log/734f737c6b57..c4e9b1332818 $ git log 734f737c6..c4e9b1332 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 nednguyen Revert "Add --enable-automation flag in GetFromBrowserOptions()" 2018-03-22 dtu [pinpoint] Set auto_explore == True for "patch jobs". 2018-03-21 ynovikov Remove a note on android_optional_gpu_tests_rel from manual rolls doc. 2018-03-15 dproy Reland "More precise self time calculation" 2018-03-21 nednguyen Ignore fetchts file 2018-03-20 laszio [Telemetry] Support outputing json in benchmark_runner 2018-03-19 kjharland [Dashboard] Whitelist prod Fuchsia Garnet builder. 2018-03-20 benjhayden Fix sorting results.html 2018-03-19 horo Add --enable-automation flag in GetFromBrowserOptions() 2018-03-19 eakuefner [Dashboard] Avoid creating empty rows/histograms/tests if histograms are empty 2018-03-16 dtu [pinpoint] Infer "repository" parameter from configuration. 2018-03-19 chiniforooshan First set of thread times metrics in TBMv2 2018-03-16 erikchen Replace --enable-heap-profiling with --memlog equivalent. 2018-03-19 wangxianzhu Fix visual rect support for cc::DisplayItemList Created with: roll-dep src/third_party/catapult BUG=chromium:822258, chromium:786572 , chromium:731979 ,chromium:821531,chromium:821521, chromium:819969 ,chromium:822258, chromium:627461 , chromium:822843 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I8c0025df6198bf9b1662bb8d78e45741d66f6aff Reviewed-on: https://chromium-review.googlesource.com/977884 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545441} [modify] https://crrev.com/6aea1cac122502499713bfc182d0454d0f325fa9/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37097a9654e57b16126e79849eb01df3366e8fb3 commit 37097a9654e57b16126e79849eb01df3366e8fb3 Author: erikchen <erikchen@chromium.org> Date: Tue May 22 20:28:47 2018 Remove implementation of legacy heap profiler. This CL removes unused code. It has no intended behavior change. The out of process heap profiler [see components/heap_profiling and components/services/heap_profiling] has replaced the legacy heap profiler. This CL removes the implementation and allocator hooks. Future CLs will remove the plumbing to enable/disable legacy heap profiler. Bug: 822843 Change-Id: I79e320c3f17bacf2414c5d0815b5feb4288de7d7 Reviewed-on: https://chromium-review.googlesource.com/1066576 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#560757} [modify] https://crrev.com/37097a9654e57b16126e79849eb01df3366e8fb3/base/BUILD.gn [delete] https://crrev.com/cbb0df9be96b42de22613b05520fb11d718910e8/base/trace_event/heap_profiler_allocation_register.cc [delete] https://crrev.com/cbb0df9be96b42de22613b05520fb11d718910e8/base/trace_event/heap_profiler_allocation_register.h [delete] https://crrev.com/cbb0df9be96b42de22613b05520fb11d718910e8/base/trace_event/heap_profiler_allocation_register_posix.cc [delete] https://crrev.com/cbb0df9be96b42de22613b05520fb11d718910e8/base/trace_event/heap_profiler_allocation_register_unittest.cc [delete] https://crrev.com/cbb0df9be96b42de22613b05520fb11d718910e8/base/trace_event/heap_profiler_allocation_register_win.cc [modify] https://crrev.com/37097a9654e57b16126e79849eb01df3366e8fb3/base/trace_event/malloc_dump_provider.cc [modify] https://crrev.com/37097a9654e57b16126e79849eb01df3366e8fb3/base/trace_event/malloc_dump_provider.h [delete] https://crrev.com/cbb0df9be96b42de22613b05520fb11d718910e8/base/trace_event/sharded_allocation_register.cc [delete] https://crrev.com/cbb0df9be96b42de22613b05520fb11d718910e8/base/trace_event/sharded_allocation_register.h [modify] https://crrev.com/37097a9654e57b16126e79849eb01df3366e8fb3/chrome/test/base/memory_tracing_browsertest.cc [modify] https://crrev.com/37097a9654e57b16126e79849eb01df3366e8fb3/components/services/heap_profiling/public/cpp/allocator_shim.cc [modify] https://crrev.com/37097a9654e57b16126e79849eb01df3366e8fb3/third_party/blink/renderer/platform/heap/blink_gc_memory_dump_provider.cc [modify] https://crrev.com/37097a9654e57b16126e79849eb01df3366e8fb3/third_party/blink/renderer/platform/heap/blink_gc_memory_dump_provider.h [modify] https://crrev.com/37097a9654e57b16126e79849eb01df3366e8fb3/third_party/blink/renderer/platform/partition_alloc_memory_dump_provider.cc [modify] https://crrev.com/37097a9654e57b16126e79849eb01df3366e8fb3/third_party/blink/renderer/platform/partition_alloc_memory_dump_provider.h [modify] https://crrev.com/37097a9654e57b16126e79849eb01df3366e8fb3/tools/gn/bootstrap/bootstrap.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d commit f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d Author: erikchen <erikchen@chromium.org> Date: Fri May 25 21:30:57 2018 Remove dead code for legacy heap profiler. This CL is a refactor with no intended behavior change. This CL: * Removes the mojom interface ClientProcesss::EnableHeapProfiling. * Removes the implementation, primarily hosted in MemoryDumpManager. Change-Id: Id55835da60d86520f692385930208a31206f7dce Bug: 822843 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1069000 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Siddhartha S <ssid@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#562017} [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/base/BUILD.gn [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/base/memory/discardable_shared_memory_unittest.cc [delete] https://crrev.com/f877d2bf928d9fd065b5cac9e07ececd982deead/base/trace_event/heap_profiler_heap_dump_writer.cc [delete] https://crrev.com/f877d2bf928d9fd065b5cac9e07ececd982deead/base/trace_event/heap_profiler_heap_dump_writer.h [delete] https://crrev.com/f877d2bf928d9fd065b5cac9e07ececd982deead/base/trace_event/heap_profiler_heap_dump_writer_unittest.cc [delete] https://crrev.com/f877d2bf928d9fd065b5cac9e07ececd982deead/base/trace_event/heap_profiler_serialization_state.cc [delete] https://crrev.com/f877d2bf928d9fd065b5cac9e07ececd982deead/base/trace_event/heap_profiler_serialization_state.h [delete] https://crrev.com/f877d2bf928d9fd065b5cac9e07ececd982deead/base/trace_event/heap_profiler_stack_frame_deduplicator.cc [delete] https://crrev.com/f877d2bf928d9fd065b5cac9e07ececd982deead/base/trace_event/heap_profiler_stack_frame_deduplicator.h [delete] https://crrev.com/f877d2bf928d9fd065b5cac9e07ececd982deead/base/trace_event/heap_profiler_stack_frame_deduplicator_unittest.cc [delete] https://crrev.com/f877d2bf928d9fd065b5cac9e07ececd982deead/base/trace_event/heap_profiler_type_name_deduplicator.cc [delete] https://crrev.com/f877d2bf928d9fd065b5cac9e07ececd982deead/base/trace_event/heap_profiler_type_name_deduplicator.h [delete] https://crrev.com/f877d2bf928d9fd065b5cac9e07ececd982deead/base/trace_event/heap_profiler_type_name_deduplicator_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/base/trace_event/java_heap_dump_provider_android_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/base/trace_event/memory_allocator_dump_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/base/trace_event/memory_dump_manager.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/base/trace_event/memory_dump_manager.h [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/base/trace_event/memory_dump_manager_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/base/trace_event/memory_dump_provider.h [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/base/trace_event/process_memory_dump.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/base/trace_event/process_memory_dump.h [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/base/trace_event/process_memory_dump_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/components/discardable_memory/common/discardable_shared_memory_heap_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/components/tracing/BUILD.gn [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/components/tracing/common/graphics_memory_dump_provider_android_unittest.cc [delete] https://crrev.com/f877d2bf928d9fd065b5cac9e07ececd982deead/components/tracing/test/heap_profiler_perftest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/content/browser/tracing/background_memory_tracing_observer.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/content/browser/tracing/background_memory_tracing_observer.h [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/content/browser/tracing/background_memory_tracing_observer_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/gin/v8_isolate_memory_dump_provider_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/mojo/edk/system/handle_table_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/net/disk_cache/backend_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/net/http/http_cache_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/net/spdy/spdy_session_pool_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/net/ssl/ssl_client_session_cache_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/net/url_request/url_request_context_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/services/resource_coordinator/memory_instrumentation/graph_processor_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.h [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation.typemap [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation_mojom_traits.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation_mojom_traits.h [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation_mojom_traits_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/services/resource_coordinator/public/mojom/memory_instrumentation/memory_instrumentation.mojom [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/skia/ext/skia_memory_dump_provider_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/sql/connection_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/sql/sql_memory_dump_provider_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/third_party/blink/renderer/platform/exported/platform.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/third_party/blink/renderer/platform/heap/blink_gc_memory_dump_provider.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/third_party/blink/renderer/platform/heap/blink_gc_memory_dump_provider_test.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/third_party/blink/renderer/platform/instrumentation/tracing/web_process_memory_dump.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/third_party/blink/renderer/platform/instrumentation/tracing/web_process_memory_dump_test.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/third_party/leveldatabase/env_chromium_unittest.cc [modify] https://crrev.com/f62ea04b8e2b89eb110b1615c905fa8ffdb3b90d/ui/android/resources/resource_manager_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3234223cf7b4853d379e6c0728de26f4d135f48b commit 3234223cf7b4853d379e6c0728de26f4d135f48b Author: erikchen <erikchen@chromium.org> Date: Wed May 30 15:20:04 2018 Remove unused code from BackgroundMemoryTracingObserver. The class only needs to trigger a memory dump for light heap profiling to work. Bug: 822843 Change-Id: I2da1cda226458f6b8b642f045f8142d561fc3ea8 Reviewed-on: https://chromium-review.googlesource.com/1076495 Reviewed-by: Siddhartha S <ssid@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#562830} [modify] https://crrev.com/3234223cf7b4853d379e6c0728de26f4d135f48b/content/browser/tracing/background_memory_tracing_observer.cc [modify] https://crrev.com/3234223cf7b4853d379e6c0728de26f4d135f48b/content/browser/tracing/background_memory_tracing_observer.h [delete] https://crrev.com/467d4e4fad7e8002f734e3ee00ee1bdafaa46408/content/browser/tracing/background_memory_tracing_observer_unittest.cc [modify] https://crrev.com/3234223cf7b4853d379e6c0728de26f4d135f48b/content/test/BUILD.gn
Comment 1 by bugdroid1@chromium.org
, Mar 19 2018