This flag has been on by default for many milestones and serves no current purpose. We should just remove it and stop trying to handle it being set to false.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0aa77e4298f78f240c03703d7260eb750bc4d549 commit 0aa77e4298f78f240c03703d7260eb750bc4d549 Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Mar 22 20:25:48 2018 Remove VrShell feature flag, clean up browsing enabled state. Removes the long unused VrShell feature flag and unifies the code that checks whether VR browsing is enabled. Also moves a bunch of static functions around (I'm trying to keep static functions above the constructor, and private functions below in an effort to make the code more readable...). I'll probably pull a lot of the statics out into their own file soon... Bug: 822810 Change-Id: Ia9523151310ef9525f3e1f3f5b8e5b5c9dcd42ba Reviewed-on: https://chromium-review.googlesource.com/972438 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#545222} [modify] https://crrev.com/0aa77e4298f78f240c03703d7260eb750bc4d549/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/0aa77e4298f78f240c03703d7260eb750bc4d549/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/0aa77e4298f78f240c03703d7260eb750bc4d549/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/TestVrShellDelegate.java [modify] https://crrev.com/0aa77e4298f78f240c03703d7260eb750bc4d549/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java [modify] https://crrev.com/0aa77e4298f78f240c03703d7260eb750bc4d549/chrome/browser/about_flags.cc [modify] https://crrev.com/0aa77e4298f78f240c03703d7260eb750bc4d549/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/0aa77e4298f78f240c03703d7260eb750bc4d549/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/0aa77e4298f78f240c03703d7260eb750bc4d549/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/0aa77e4298f78f240c03703d7260eb750bc4d549/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/0aa77e4298f78f240c03703d7260eb750bc4d549/chrome/browser/flag_descriptions.h [modify] https://crrev.com/0aa77e4298f78f240c03703d7260eb750bc4d549/chrome/common/chrome_features.cc
Comment 1 by mthiesse@chromium.org
, Mar 22 2018