New issue
Advanced search Search tips

Issue 822803 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: 3
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 821991



Sign in to add a comment

Update style of text inputs for MD refresh

Project Member Reported by kylixrd@chromium.org, Mar 16 2018

Issue description

Changes to Textfield in spec.
 
Components: Internals>Views
Status: Available
Summary: Update style of text inputs for MD refresh (was: Update style of dropdowns and text inputs for MD refresh)
Description: Show this description
Blocking: 821991
Owner: bsep@chromium.org
Status: Assigned (was: Available)

Comment 6 by bettes@chromium.org, Apr 18 2018

From go/chrome-ux-gm2:
https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g34d24941d1_37_111


Screen Shot 2018-04-18 at 4.56.25 PM.png
110 KB View Download
Screen Shot 2018-04-18 at 4.56.30 PM.png
93.9 KB View Download
EstimatedDays: 3
bsep@: what's left to do here?
Labels: -Pri-3 Pri-1
Since this is highly visible in password sync dialog, upping to P1.

Comment 10 by bsep@chromium.org, May 31 2018

I haven't done any work on this, except that I increased the size along with the buttons. I can undo that change very quickly if we cut this for scope.

Comment 11 by bsep@chromium.org, Jun 1 2018

Labels: -Pri-1 Pri-3
Dropping priority after discussion. Secondary UI is less important than the primary UI work.
Labels: M-70
Labels: -M-70 Group-Platform
Labels: M-70
Discovered that inputs were 36dp tall. Asking bsep@ to reduce inputs to 32dp as an interim solution to completing this bug. 
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf218b7dd03fb03dd62474b3f4c68a1966fe538f

commit cf218b7dd03fb03dd62474b3f4c68a1966fe538f
Author: Bret Sepulveda <bsep@chromium.org>
Date: Fri Jul 13 18:49:17 2018

Change size of comboboxes and text input controls to 32 dips.

Their size is now consistent with buttons.

Bug: 822803, 822074
Change-Id: I26742d82262efb0c2329fdcb313126ad681965ea
Reviewed-on: https://chromium-review.googlesource.com/1136061
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574998}
[modify] https://crrev.com/cf218b7dd03fb03dd62474b3f4c68a1966fe538f/chrome/browser/ui/views/harmony/material_refresh_layout_provider.cc

Labels: Target-70
Labels: Proj-DesktopUI
Labels: Pri-1
Labels: -M-70 -Target-70 M-71 Target-71
Labels: -Group-Platform Group-Dialogs
Labels: Hotlist-MdRefreshDesignPolish
Labels: -Proj-MdRefresh
Labels: Hotlist-DesktopUITriaged
Labels: -M-71 -Target-71 M-72 Target-72
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIToolingRequired
Labels: -M-72 -Target-72 M-73 Target-73

Sign in to add a comment