Issue metadata
Sign in to add a comment
|
New "anti-redirect" code has broken multiple functions/operations in Chrome
Reported by
collin.c...@blueprairie.com,
Mar 16 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.26 Safari/537.36 Steps to reproduce the problem: 1. Open Chrome 2. Browse to any site 3. Attempt one of many operations including but not limited to: a) Downloading a file b) Perform normal Chrome site navigation c) Enable ANY fully-supported Chrome extension installed from the Chrome web store that performs ANY redirection-based operations What is the expected behavior? Matching the above operations in "steps to reproduce" section: a) File downloads or select download location window appears b) Successful navigation c) Normal extension operations What went wrong? Matching the above operations in "steps to reproduce" section: a) File does NOT download and instead the new anti-redirection (mini-ad-blocking?)_code prevents download with this indicator: https://i.imgur.com/eRTsI47.png b) Navigation is at times interrupted with: https://i.imgur.com/Re4NwXx.png c) Extension operations instead generate: https://i.imgur.com/90nqnk9.png Did this work before? Yes v65 Chrome version: 66.0.3359.26 Channel: dev OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: I have attempted to disable the new built-in ad-blocking with the flag #enable-framebusting-needs-sameorigin-or-usergesture, and it does not seem to rectify (DISABLE) this new behavior. Again the order of this bug is: 1. This appears in the omni-bar: https://i.imgur.com/Re4NwXx.png 2. It then quickly collapses to this which I believe is why many users have no idea it is even occurring: https://i.imgur.com/UFlyucZ.png 3. Clicking this new icon reveals this new redirection blocking either with file, URL, or chrome-extension location - Examples: File: https://i.imgur.com/eRTsI47.png URL: (Same as file) chrome-extension: https://i.imgur.com/90nqnk9.png **Of interest/note: The above file redirect block was literally only after downloading OVER A DOZEN zip files from the EXACT SAME base URL! So, half-way through 20+ free file downloads, Chrome literally CHANGED how it interpreted that site and suddenly, in the same session, and SAME BASE TAB (all downloads were launched one at a time into new tabs) began to block simple file downloads and began interpreting them as "redirections". This also absolutely aligns with what I see using the extension "The Great Suspender" (and others), that in the case of TGS in essence redirects to a suspended local page to free resources. With this new Chrome code however, a totally RANDOM set of locations (of which some will work then suddenly stop) will be blocked and then later Chrome again changes it's mind and allows them to suspend (redirect). This new code is clearly not ready for prime-time since at best, it is totally inconsistent. I may also take some screen captures showing this behavior if I get some time and if needed. There should be a Chrome flag at the very least to simply disable ALL of this new redirection behavior and continue with the pre-v66 behavior, that I initially believed the #enable-framebusting-needs-sameorigin-or-usergesture flag was intended to do.
,
Mar 19 2018
Unable to reproduce the issue on Win-7 and Win-10 using chrome reported version #66.0.3359.26 and latest canary #67.0.3374.0. Attached a screen cast for reference. Following are the steps followed to reproduce the issue. ------------ 1. Opened Chrome 2. Browsed to a site for downloading sample test files which redirected to a page and downloaded the sample test file. 3. Added an extension "The Great Suspender" which on being added to chrome redirected to another page without any issues. reporter@ - Could you please check the screen cast and please let us know if anything missed from our end. Also please check the issue on latest canary #67.0.3374.0 by creating a new profile without any apps and extensions and please let us know if the issue still persist or not. Thanks...!!
,
Apr 2 2018
I think this is fallout from the "tab-under blocking" which is still in experimentation on dev channel. I was able to reproduce the issue with the great suspender extension. However, I wasn't able to reproduce in M67 for the downloads case. I'll investigate.
,
Apr 2 2018
collin.chaffin@, are you still seeing all three bugs in the most recent Chrome dev (67)? I have a fix for the extensions case, but the other two are not obvious to me.
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2202082cd0cd186acbda7811bdbd961a2febbbe commit f2202082cd0cd186acbda7811bdbd961a2febbbe Author: Charlie Harrison <csharrison@chromium.org> Date: Wed May 02 18:09:34 2018 [tab-under] Exempt navigations to and from chrome-extension schemes Extensions (like the Great Suspender) want to be able to navigate tabs in the background. Often these tabs will have opened a popup since their last user gesture, classifying them as tab-unders. This CL allows tab-under navigations to and from chrome-extension schemes, allowing extensions arbitrary redirection as long as they can round trip through some extension resource. Bug: 822791 Change-Id: I33b160f0204e2485582432c8ccf2a6722f9721bd Reviewed-on: https://chromium-review.googlesource.com/1039647 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#555466} [modify] https://crrev.com/f2202082cd0cd186acbda7811bdbd961a2febbbe/chrome/browser/ui/blocked_content/tab_under_blocker_browsertest.cc [modify] https://crrev.com/f2202082cd0cd186acbda7811bdbd961a2febbbe/chrome/browser/ui/blocked_content/tab_under_navigation_throttle.cc
,
May 11 2018
Going to mark this as fixed, since it fixes the Great Suspender. Reporter: would you mind filing a new issue with repeatable steps if you are still facing issues? You can post a link to the new bug here. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by krajshree@chromium.org
, Mar 19 2018