The standard defines: https://wicg.github.io/background-fetch/#backgroundfetchsettledevent Our code currently calls it BackgroundFetchedEvent (https://cs.chromium.org/search/?q=BackgroundFetchEvent&sq=package:chromium&type=cs). It needs to be updated to BackgroundFetchSettledEvent. @rayankans would like to take a stab at it, so assigning it to him.
The standard defines: https://wicg.github.io/background-fetch/#backgroundfetchsettledevent Our code currently calls it BackgroundFetchedEvent (https://cs.chromium.org/search/?q=BackgroundFetchedEvent&sq=package:chromium&type=cs). It needs to be updated to BackgroundFetchSettledEvent. @rayankans would like to take a stab at it, so assigning it to him.
Note, we still need to figure out how to solve the following error in the layout tests: FAIL BackgroundFetchSettledEvent interface: existence and properties of interface prototype object Cannot read property 'has_stringifier' of undefined.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22db776a23d41dfaba27400e386dc0143b2d2582 commit 22db776a23d41dfaba27400e386dc0143b2d2582 Author: Rayan Kanso <rayankans@chromium.org> Date: Mon Apr 09 18:10:11 2018 [Background Fetch] Add BackgroundFetchSettledEvent idl files and basic implementation. Specs are defined in https://wicg.github.io/background-fetch/#backgroundfetchsettledevent. This is the first step in replacing the BackgroundFetched* API. Bug: 822765 Change-Id: Ib725b0c389edc32563f45bd26d72621b7031ad31 Reviewed-on: https://chromium-review.googlesource.com/975549 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#549226} [modify] https://crrev.com/22db776a23d41dfaba27400e386dc0143b2d2582/third_party/WebKit/LayoutTests/external/wpt/background-fetch/interfaces-worker.https-expected.txt [modify] https://crrev.com/22db776a23d41dfaba27400e386dc0143b2d2582/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/22db776a23d41dfaba27400e386dc0143b2d2582/third_party/blink/renderer/modules/BUILD.gn [modify] https://crrev.com/22db776a23d41dfaba27400e386dc0143b2d2582/third_party/blink/renderer/modules/background_fetch/BUILD.gn [add] https://crrev.com/22db776a23d41dfaba27400e386dc0143b2d2582/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_event.cc [add] https://crrev.com/22db776a23d41dfaba27400e386dc0143b2d2582/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_event.h [add] https://crrev.com/22db776a23d41dfaba27400e386dc0143b2d2582/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_event.idl [add] https://crrev.com/22db776a23d41dfaba27400e386dc0143b2d2582/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_event_init.idl [add] https://crrev.com/22db776a23d41dfaba27400e386dc0143b2d2582/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetches.cc [add] https://crrev.com/22db776a23d41dfaba27400e386dc0143b2d2582/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetches.h [add] https://crrev.com/22db776a23d41dfaba27400e386dc0143b2d2582/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetches.idl [add] https://crrev.com/22db776a23d41dfaba27400e386dc0143b2d2582/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetches_test.cc [modify] https://crrev.com/22db776a23d41dfaba27400e386dc0143b2d2582/third_party/blink/renderer/modules/modules_idl_files.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fee9bb13118493fda27558b1b3e5d69e57e5b689 commit fee9bb13118493fda27558b1b3e5d69e57e5b689 Author: Rayan Kanso <rayankans@chromium.org> Date: Tue Apr 10 19:48:54 2018 [Background Fetch] Add BackgroundFetchUpdateEvent idl files and basic implementation. Update UI logic was copied from background_fetched_event.cc. The goal is to deprecate BackgroundFetchedEvent and be compliant with the specs defined in https://wicg.github.io/background-fetch/#backgroundfetchupdateevent TBR=jbroman@chromium.org Bug: 822765 Change-Id: I75e295ca205548421daef73dab6f5b3dc236733f Reviewed-on: https://chromium-review.googlesource.com/1002179 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#549617} [modify] https://crrev.com/fee9bb13118493fda27558b1b3e5d69e57e5b689/third_party/WebKit/LayoutTests/external/wpt/background-fetch/interfaces-worker.https-expected.txt [modify] https://crrev.com/fee9bb13118493fda27558b1b3e5d69e57e5b689/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/fee9bb13118493fda27558b1b3e5d69e57e5b689/third_party/blink/renderer/modules/background_fetch/BUILD.gn [modify] https://crrev.com/fee9bb13118493fda27558b1b3e5d69e57e5b689/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_event.cc [modify] https://crrev.com/fee9bb13118493fda27558b1b3e5d69e57e5b689/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_event.h [add] https://crrev.com/fee9bb13118493fda27558b1b3e5d69e57e5b689/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.cc [add] https://crrev.com/fee9bb13118493fda27558b1b3e5d69e57e5b689/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.h [add] https://crrev.com/fee9bb13118493fda27558b1b3e5d69e57e5b689/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.idl [modify] https://crrev.com/fee9bb13118493fda27558b1b3e5d69e57e5b689/third_party/blink/renderer/modules/modules_idl_files.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18f96488cea6fe904407750b0ef94ea307953fdc commit 18f96488cea6fe904407750b0ef94ea307953fdc Author: Rayan Kanso <rayankans@chromium.org> Date: Thu Apr 12 16:40:31 2018 [Background Fetch] Replace BackgroundFetchedEvent w/BackgroundFetchUpdateEvent Dispatch instance of BackgroundFetchUpdateEvent with a backgroundfetched event. Add suitable constructors to BackgroundFetchUpdateEvent and BackgroundFetchSettledFetches. Add WebKit Layout test for BackgroundFetchUpdateEvent. Bug: 822765 Change-Id: I557bd4f599009841444cbe2cbc53c4419e37892f Reviewed-on: https://chromium-review.googlesource.com/1005055 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#550239} [delete] https://crrev.com/d2fae28bd46829726be30544adeb149e02cd97f1/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-click-event.https-expected.txt [delete] https://crrev.com/d2fae28bd46829726be30544adeb149e02cd97f1/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-event.https-expected.txt [delete] https://crrev.com/d2fae28bd46829726be30544adeb149e02cd97f1/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-fail-event.https-expected.txt [add] https://crrev.com/18f96488cea6fe904407750b0ef94ea307953fdc/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-update-event.https.html [delete] https://crrev.com/d2fae28bd46829726be30544adeb149e02cd97f1/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetched-event.https-expected.txt [delete] https://crrev.com/d2fae28bd46829726be30544adeb149e02cd97f1/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetched-event.https.html [modify] https://crrev.com/18f96488cea6fe904407750b0ef94ea307953fdc/third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-click-event-worker.js [modify] https://crrev.com/18f96488cea6fe904407750b0ef94ea307953fdc/third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-event-worker.js [modify] https://crrev.com/18f96488cea6fe904407750b0ef94ea307953fdc/third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-fail-event-worker.js [add] https://crrev.com/18f96488cea6fe904407750b0ef94ea307953fdc/third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-update-event-worker.js [delete] https://crrev.com/d2fae28bd46829726be30544adeb149e02cd97f1/third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetched-event-worker.js [modify] https://crrev.com/18f96488cea6fe904407750b0ef94ea307953fdc/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetches.h [modify] https://crrev.com/18f96488cea6fe904407750b0ef94ea307953fdc/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetches_test.cc [modify] https://crrev.com/18f96488cea6fe904407750b0ef94ea307953fdc/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.h [modify] https://crrev.com/18f96488cea6fe904407750b0ef94ea307953fdc/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/baef242937944f697ea7b36a44c4eba06c2c49a3 commit baef242937944f697ea7b36a44c4eba06c2c49a3 Author: Rayan Kanso <rayankans@chromium.org> Date: Mon May 14 15:19:04 2018 [Background Fetch] Update background fetch abort & fail dispatchers. Update the backgroundfetchfail & backgroundfetchabort event types to instantiate BackgroundFetchUpdateEvent & BackgroundFetchSettledEvent respectively. https://wicg.github.io/background-fetch/#service-worker-global-events Bug: 822765 Change-Id: Iea5311fdbedf805ec8d4d54daca0257078dc050d Reviewed-on: https://chromium-review.googlesource.com/1005177 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#558313} [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/content/browser/background_fetch/background_fetch_context.cc [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.cc [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.h [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/content/browser/background_fetch/background_fetch_event_dispatcher.cc [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/content/browser/background_fetch/background_fetch_event_dispatcher.h [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/content/common/service_worker/service_worker_event_dispatcher.mojom [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/content/renderer/service_worker/service_worker_context_client_unittest.cc [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/third_party/blink/public/web/modules/serviceworker/web_service_worker_context_proxy.h [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_event.cc [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_event.h [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.cc [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.h [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.cc [modify] https://crrev.com/baef242937944f697ea7b36a44c4eba06c2c49a3/third_party/blink/renderer/modules/serviceworkers/service_worker_global_scope_proxy.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7206154fb4970f43ef7b485348cdf32c88d9266 commit f7206154fb4970f43ef7b485348cdf32c88d9266 Author: Rayan Kanso <rayankans@chromium.org> Date: Mon Jul 23 21:34:01 2018 [Background Fetch] Delete the unused FetchedEvent files. TBR=jbroman@chromium.org Bug: 822765 Change-Id: I03fa9efc6fa80814f252593a0582ff25b633580b Reviewed-on: https://chromium-review.googlesource.com/1142154 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#577271} [modify] https://crrev.com/f7206154fb4970f43ef7b485348cdf32c88d9266/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/f7206154fb4970f43ef7b485348cdf32c88d9266/third_party/blink/renderer/bindings/modules/BUILD.gn [modify] https://crrev.com/f7206154fb4970f43ef7b485348cdf32c88d9266/third_party/blink/renderer/modules/background_fetch/BUILD.gn [delete] https://crrev.com/e514dd71ee11ae1a8be2c7c61b8a563cee6350fb/third_party/blink/renderer/modules/background_fetch/background_fetched_event.cc [delete] https://crrev.com/e514dd71ee11ae1a8be2c7c61b8a563cee6350fb/third_party/blink/renderer/modules/background_fetch/background_fetched_event.h [delete] https://crrev.com/e514dd71ee11ae1a8be2c7c61b8a563cee6350fb/third_party/blink/renderer/modules/background_fetch/background_fetched_event.idl [delete] https://crrev.com/e514dd71ee11ae1a8be2c7c61b8a563cee6350fb/third_party/blink/renderer/modules/background_fetch/background_fetched_event_init.idl [modify] https://crrev.com/f7206154fb4970f43ef7b485348cdf32c88d9266/third_party/blink/renderer/modules/modules_idl_files.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9329f7417d061825d7facde455ca22ad2a49007f commit 9329f7417d061825d7facde455ca22ad2a49007f Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Mon Jul 23 22:05:14 2018 Revert "[Background Fetch] Delete the unused FetchedEvent files." This reverts commit f7206154fb4970f43ef7b485348cdf32c88d9266. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 577271 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Y3MjA2MTU0ZmI0OTcwZjQzZWY3YjQ4NTM0OGNkZjMyYzg4ZDkyNjYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Linux%20x64/70091 Sample Failed Step: compile Original change's description: > [Background Fetch] Delete the unused FetchedEvent files. > > TBR=jbroman@chromium.org > > Bug: 822765 > Change-Id: I03fa9efc6fa80814f252593a0582ff25b633580b > Reviewed-on: https://chromium-review.googlesource.com/1142154 > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Reviewed-by: Mugdha Lakhani <nator@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577271} Change-Id: Ic3771c3853efcdcc742d5aadcbfdf8377b73c7d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 822765 Reviewed-on: https://chromium-review.googlesource.com/1146941 Cr-Commit-Position: refs/heads/master@{#577275} [modify] https://crrev.com/9329f7417d061825d7facde455ca22ad2a49007f/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/9329f7417d061825d7facde455ca22ad2a49007f/third_party/blink/renderer/bindings/modules/BUILD.gn [modify] https://crrev.com/9329f7417d061825d7facde455ca22ad2a49007f/third_party/blink/renderer/modules/background_fetch/BUILD.gn [add] https://crrev.com/9329f7417d061825d7facde455ca22ad2a49007f/third_party/blink/renderer/modules/background_fetch/background_fetched_event.cc [add] https://crrev.com/9329f7417d061825d7facde455ca22ad2a49007f/third_party/blink/renderer/modules/background_fetch/background_fetched_event.h [add] https://crrev.com/9329f7417d061825d7facde455ca22ad2a49007f/third_party/blink/renderer/modules/background_fetch/background_fetched_event.idl [add] https://crrev.com/9329f7417d061825d7facde455ca22ad2a49007f/third_party/blink/renderer/modules/background_fetch/background_fetched_event_init.idl [modify] https://crrev.com/9329f7417d061825d7facde455ca22ad2a49007f/third_party/blink/renderer/modules/modules_idl_files.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3267e09ecf6df79e7089450dcd0a6ca9133b152a commit 3267e09ecf6df79e7089450dcd0a6ca9133b152a Author: Rayan Kanso <rayankans@chromium.org> Date: Tue Jul 24 11:57:32 2018 Reland "[Background Fetch] Delete the unused FetchedEvent files." This is a reland of f7206154fb4970f43ef7b485348cdf32c88d9266 Original change's description: > [Background Fetch] Delete the unused FetchedEvent files. > > TBR=jbroman@chromium.org > > Bug: 822765 > Change-Id: I03fa9efc6fa80814f252593a0582ff25b633580b > Reviewed-on: https://chromium-review.googlesource.com/1142154 > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Reviewed-by: Mugdha Lakhani <nator@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577271} Bug: 822765 Change-Id: I1e8e31569874b6be9de954cc15ac01f6b134017d Reviewed-on: https://chromium-review.googlesource.com/1148260 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577486} [modify] https://crrev.com/3267e09ecf6df79e7089450dcd0a6ca9133b152a/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/3267e09ecf6df79e7089450dcd0a6ca9133b152a/third_party/blink/renderer/bindings/modules/BUILD.gn [modify] https://crrev.com/3267e09ecf6df79e7089450dcd0a6ca9133b152a/third_party/blink/renderer/modules/background_fetch/BUILD.gn [modify] https://crrev.com/3267e09ecf6df79e7089450dcd0a6ca9133b152a/third_party/blink/renderer/modules/background_fetch/background_fetch_update_event.cc [delete] https://crrev.com/458044469ddf4968bf275ffbd93fdff702cefa66/third_party/blink/renderer/modules/background_fetch/background_fetched_event.cc [delete] https://crrev.com/458044469ddf4968bf275ffbd93fdff702cefa66/third_party/blink/renderer/modules/background_fetch/background_fetched_event.h [delete] https://crrev.com/458044469ddf4968bf275ffbd93fdff702cefa66/third_party/blink/renderer/modules/background_fetch/background_fetched_event.idl [delete] https://crrev.com/458044469ddf4968bf275ffbd93fdff702cefa66/third_party/blink/renderer/modules/background_fetch/background_fetched_event_init.idl [modify] https://crrev.com/3267e09ecf6df79e7089450dcd0a6ca9133b152a/third_party/blink/renderer/modules/modules_idl_files.gni
Comment 1 by na...@chromium.org
, Mar 16 2018