New issue
Advanced search Search tips

Issue 822763 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
Modern-Media-Controls


Sign in to add a comment

can't pause video with new media UI on android

Project Member Reported by liber...@chromium.org, Mar 16 2018

Issue description

Chrome Version: ToT
OS: android (nexus 5x)

What steps will reproduce the problem?
(1) https://storage.googleapis.com/watk-public/v
(2) click the upper left hand box (small mp4 video)
(3) play
(4) try to pause with the overlay pause button.

usually, it ignores me and keeps playing.  rarely, it pauses.
 
I ran into a case with xorax.sea/garden2_10s.mp4 that there seems to be no pause button... using spacebar seemed to pause just fine though.
Cc: -steimel@chromium.org mlamouri@chromium.org
Owner: steimel@chromium.org
Just tried on 66.0.3359.30 on my Pixel 2 and it seems to work fine. The website isn't made for mobile so the click target is a bit small.
here's a video:

https://drive.google.com/file/d/1WijqfA-2cqqFEj-BAtnbW63t8WWNldoT/view?usp=sharing

note that it might be a touch target thing -- when i zoomed very far in, i could pause it.  however, "a bit small" is a bit of an understatement.  :)
Status: Started (was: Assigned)
Labels: -Pri-2 Pri-1
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f05ffc1a34114a8b91c5bf4bf78c79c828134860

commit f05ffc1a34114a8b91c5bf4bf78c79c828134860
Author: Tommy Steimel <steimel@chromium.org>
Date: Tue Apr 03 14:21:42 2018

Ignore certain pointer events when the user interacts via touch

This CL adds a bool to track whether the user is interacting via touch
or mouse. When the user is interacting via touch, we ignore certain
pointer events that were causing many issues on Android (or any touch-
enabled device).

In particular, this fixes an issue where users were unable to use the
overlay play button in certain cases. The underlying chain of events
that caused the button to not receive a tap was:

1) While controls are shown, user taps on overlay play button to pause
2) MediaControlsImpl sees a pointerout event from the user's tap, and
   stops the hide timer
3) OnTimeUpdate fired, seeing a stopped timer and hiding the controls
4) MediaControlsImpl sees a gesturetap from the user's tap, and decides
   to show the controls
5) The controls reappear, but the user's tap has already been handled
   and the overlay play button sees nothing

Bug:  822763 
Change-Id: Ia085c7f1cd082c0f44b60f22333146cd6de5f841
Reviewed-on: https://chromium-review.googlesource.com/982900
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547695}
[modify] https://crrev.com/f05ffc1a34114a8b91c5bf4bf78c79c828134860/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/f05ffc1a34114a8b91c5bf4bf78c79c828134860/third_party/WebKit/LayoutTests/media/controls/modern/singletouch-on-play-button.html
[modify] https://crrev.com/f05ffc1a34114a8b91c5bf4bf78c79c828134860/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/f05ffc1a34114a8b91c5bf4bf78c79c828134860/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/f05ffc1a34114a8b91c5bf4bf78c79c828134860/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on Chrome:67.0.3393.1 Device:HTC ONE A9/NRD90M

Sign in to add a comment