New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822758 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

cryptohome tpm_attestation_start_cert_request should be able to specify cert profile and origin

Project Member Reported by drcrash@chromium.org, Mar 16 2018

Issue description

We want to mirror what we have in attestation_client
 
Cc: apronin@chromium.org mvanotti@google.com igorcov@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7507867f80c1404605513df58d14b44db82e45a4

commit 7507867f80c1404605513df58d14b44db82e45a4
Author: Yves Arrouye <drcrash@google.com>
Date: Mon Mar 19 21:19:05 2018

cryptohome: support certificate profiles like attestation_client does

BUG= chromium:822758 
TEST=manual

Change-Id: Id421b342ec3af859cbbd74f700543f89dc5ca893
Reviewed-on: https://chromium-review.googlesource.com/967722
Commit-Ready: Yves Arrouye <drcrash@chromium.org>
Tested-by: Yves Arrouye <drcrash@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/7507867f80c1404605513df58d14b44db82e45a4/cryptohome/cryptohome.cc

Status: Verified (was: Assigned)
Status: Assigned (was: Verified)
Reopening to fix some other egregious behavior related to user-specific when finishing certs.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f37525c9e401b31006414d6281d7c115f208ab3c

commit f37525c9e401b31006414d6281d7c115f208ab3c
Author: Yves Arrouye <drcrash@google.com>
Date: Tue Apr 03 23:12:22 2018

cryptohome: do validate CA and VA parameters and fix user-specific issue

The bug fixed is that the command relies on magic names for certs
instead of better information.

BUG= chromium:822758 
TEST=manual

Change-Id: I5fb96e048e7a619ea925dcf9a7fc974ecda5ab4d
Reviewed-on: https://chromium-review.googlesource.com/984722
Commit-Ready: Yves Arrouye <drcrash@chromium.org>
Tested-by: Yves Arrouye <drcrash@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/f37525c9e401b31006414d6281d7c115f208ab3c/cryptohome/cryptohome.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5628d9b9712266d8a7b0f0ee6e83b743f621eafd

commit 5628d9b9712266d8a7b0f0ee6e83b743f621eafd
Author: Yves Arrouye <drcrash@google.com>
Date: Tue Apr 03 23:12:23 2018

cryptohome: add --input and --output options

The --input and --output options allows one to separate the input and
output files. This is useful for instance when debugging so as not to
clobber CA responses.

The cryptohome command will read input files using either the value of
--input or that of --file if --input is not provided. It will write
output files using either the value of --output or that of --file if
--output is not provided. This affords backwards compatibility with
current usage.

BUG= chromium:822758 
TEST=manual

Change-Id: I8cd98f25ab19eaf2f535527ec4d1d8d65cc4b052
Reviewed-on: https://chromium-review.googlesource.com/987033
Commit-Ready: Yves Arrouye <drcrash@chromium.org>
Tested-by: Yves Arrouye <drcrash@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/5628d9b9712266d8a7b0f0ee6e83b743f621eafd/cryptohome/cryptohome.cc

Status: Verified (was: Assigned)

Sign in to add a comment