New issue
Advanced search Search tips

Issue 822757 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

external/wpt/resource-timing/resource_initiator_types.html is flaky

Project Member Reported by raphael....@intel.com, Mar 16 2018

Issue description

This is a tracking bug for the flakiness in external/wpt/resource-timing/resource_initiator_types.html introduced by https://github.com/w3c/web-platform-tests/pull/9986

I'm marking the test as flaky for now to unblock our imports, but we should keep track of it upstream and remove the entry from TestExpectations when things are fixed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7321fd950bbfdfb63b38f3c76c1e5027cf9abaf

commit a7321fd950bbfdfb63b38f3c76c1e5027cf9abaf
Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Fri Mar 16 16:28:46 2018

Mark external/wpt/resource-timing/resource_initiator_types.html as flaky

https://github.com/w3c/web-platform-tests/pull/9986 has introduced some
flakiness to the test that is currently blocking WPT imports.

TBR=lukebjerring

Bug: 822757
Change-Id: Iddc3adf65989506b72fba003a2bbbd8d9cbf062f
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/966604
Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#543724}
[modify] https://crrev.com/a7321fd950bbfdfb63b38f3c76c1e5027cf9abaf/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by y...@yoav.ws, May 3 2018

Looking at the test's flakiness, it seems it is flaky because audio is failing, and because the resources actually loaded by audio (and "ogg" specifically) vary between loads :/

So it seems like it is not the test that is flaky, but media element loads
Project Member

Comment 3 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d78c1e54e74aa1947a2cfc3caa33e441cec5f53d

commit d78c1e54e74aa1947a2cfc3caa33e441cec5f53d
Author: Yoav Weiss <yoav@yoav.ws>
Date: Mon May 28 09:36:44 2018

[Resource-Timing] Fix `initiatorType` values

There were multiple issues with current `initiatorType` implementation:
* `fetch()` resources had an empty value instead of "fetch"
* `<video>` resources had an empty value instead of "video"
* `<audio>` resources had an empty value instead of "audio"
* `<track>` resources had "texttrack" value instead of "track"
* EventSource resources had an empty value instead of "other"

On top of that, the test to make sure the above is all in check had
some values that were not aligned to the spec, and was disabled due to
the flakiness of audio and video loads.

This CL fixes the above values, fixes the test to be more spec
compliant and enables it.

Bug:  649571 , 822757
Change-Id: I1dc6fd35e5e4bc570cbbb7d743dc02279bf42b8b
Reviewed-on: https://chromium-review.googlesource.com/1040925
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562221}
[modify] https://crrev.com/d78c1e54e74aa1947a2cfc3caa33e441cec5f53d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d78c1e54e74aa1947a2cfc3caa33e441cec5f53d/third_party/WebKit/LayoutTests/external/wpt/resource-timing/resource_initiator_types.html
[modify] https://crrev.com/d78c1e54e74aa1947a2cfc3caa33e441cec5f53d/third_party/blink/renderer/core/exported/web_associated_url_loader_impl.cc
[modify] https://crrev.com/d78c1e54e74aa1947a2cfc3caa33e441cec5f53d/third_party/blink/renderer/core/fetch/fetch_manager.cc
[modify] https://crrev.com/d78c1e54e74aa1947a2cfc3caa33e441cec5f53d/third_party/blink/renderer/core/loader/text_track_loader.cc
[modify] https://crrev.com/d78c1e54e74aa1947a2cfc3caa33e441cec5f53d/third_party/blink/renderer/core/timing/performance_resource_timing.cc
[modify] https://crrev.com/d78c1e54e74aa1947a2cfc3caa33e441cec5f53d/third_party/blink/renderer/platform/loader/fetch/fetch_initiator_type_names.json5
[modify] https://crrev.com/d78c1e54e74aa1947a2cfc3caa33e441cec5f53d/third_party/blink/renderer/platform/loader/fetch/resource.cc

Sign in to add a comment