Dice puts Chrome in error state when the user is syncing and signs out on the web. This is currently indistinguishable from other errors such as a password change. For UI and metrics purposes we need to make the distinction.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55373bc3fb3503bde81d39adb399b506ecadcc89 commit 55373bc3fb3503bde81d39adb399b506ecadcc89 Author: David Roger <droger@chromium.org> Date: Thu Mar 22 13:46:01 2018 [signin] Cleanup GoogleServiceAuthError and add error reason Bug: 822728 Change-Id: Iaf1de0917be3533d03da0e2aac3b9d33fb03d477 Reviewed-on: https://chromium-review.googlesource.com/966068 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#545057} [modify] https://crrev.com/55373bc3fb3503bde81d39adb399b506ecadcc89/components/signin/core/browser/account_fetcher_service.h [modify] https://crrev.com/55373bc3fb3503bde81d39adb399b506ecadcc89/google_apis/gaia/google_service_auth_error.cc [modify] https://crrev.com/55373bc3fb3503bde81d39adb399b506ecadcc89/google_apis/gaia/google_service_auth_error.h [modify] https://crrev.com/55373bc3fb3503bde81d39adb399b506ecadcc89/google_apis/gaia/google_service_auth_error_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28 commit 5122b0ecf9510e1ce4794f6ef408c54c68c3ba28 Author: David Roger <droger@chromium.org> Date: Tue Mar 27 19:50:45 2018 [signin] Specify a reason to authentication errors Updates code generating INVALID_GAIA_CREDENTIALS errors to also set an error reason. Report these error reasons in the Signin.InvalidGaiaCredentialsReason histogram. Bug: 822728 TBR: alemate Change-Id: Ie727964845f0677a31d0ab035c0dee788d2b7859 Reviewed-on: https://chromium-review.googlesource.com/966422 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#546214} [modify] https://crrev.com/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28/chrome/browser/chromeos/settings/device_oauth2_token_service.cc [modify] https://crrev.com/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc [modify] https://crrev.com/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc [modify] https://crrev.com/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28/chrome/browser/signin/oauth2_token_service_delegate_android.cc [modify] https://crrev.com/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28/chromeos/login/auth/stub_authenticator.cc [modify] https://crrev.com/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28/components/signin/core/browser/signin_error_controller.cc [modify] https://crrev.com/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28/components/signin/core/browser/signin_metrics.cc [modify] https://crrev.com/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28/components/signin/core/browser/signin_metrics.h [modify] https://crrev.com/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm [modify] https://crrev.com/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28/google_apis/gaia/gaia_auth_fetcher.cc [modify] https://crrev.com/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28/google_apis/gaia/oauth2_access_token_fetcher_impl.cc [modify] https://crrev.com/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28/tools/metrics/histograms/enums.xml [modify] https://crrev.com/5122b0ecf9510e1ce4794f6ef408c54c68c3ba28/tools/metrics/histograms/histograms.xml
Comment 1 by bugdroid1@chromium.org
, Mar 22 2018