New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822721 link

Starred by 0 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

blink platform audio uses const casts too often

Project Member Reported by eero.hak...@intel.com, Mar 16 2018

Issue description

Reducing the number of const casts and fixing constness of accessors improves  const correctness and code readability.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18408fcc6f0e2410d7b91f420d468e629eff6731

commit 18408fcc6f0e2410d7b91f420d468e629eff6731
Author: Eero Häkkinen <eero.hakkinen@intel.com>
Date: Fri Mar 16 15:30:40 2018

Remove unneeded const casts from VectorMath functions

Bug:  822721 
Change-Id: If0d5768d344580ce7da3b8cf07eaacece34614eb
Reviewed-on: https://chromium-review.googlesource.com/962141
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543706}
[modify] https://crrev.com/18408fcc6f0e2410d7b91f420d468e629eff6731/third_party/WebKit/Source/platform/audio/mac/VectorMathMac.h

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f6f6ba63ba317144d1a01599b0fefeef580aeac

commit 4f6f6ba63ba317144d1a01599b0fefeef580aeac
Author: Eero Häkkinen <eero.hakkinen@intel.com>
Date: Mon Mar 19 16:10:59 2018

Remove unneeded const casts from AudioBus and FFTFrame

This also improves const correctness of FFTFrame.

Bug:  822721 
Change-Id: I49668b37b0ecca278ce35af293eee6e324d88f4c
Reviewed-on: https://chromium-review.googlesource.com/962223
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Cr-Commit-Position: refs/heads/master@{#544053}
[modify] https://crrev.com/4f6f6ba63ba317144d1a01599b0fefeef580aeac/third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.cpp
[modify] https://crrev.com/4f6f6ba63ba317144d1a01599b0fefeef580aeac/third_party/WebKit/Source/platform/audio/AudioBus.cpp
[modify] https://crrev.com/4f6f6ba63ba317144d1a01599b0fefeef580aeac/third_party/WebKit/Source/platform/audio/AudioBus.h
[modify] https://crrev.com/4f6f6ba63ba317144d1a01599b0fefeef580aeac/third_party/WebKit/Source/platform/audio/FFTConvolver.cpp
[modify] https://crrev.com/4f6f6ba63ba317144d1a01599b0fefeef580aeac/third_party/WebKit/Source/platform/audio/FFTConvolver.h
[modify] https://crrev.com/4f6f6ba63ba317144d1a01599b0fefeef580aeac/third_party/WebKit/Source/platform/audio/FFTFrame.cpp
[modify] https://crrev.com/4f6f6ba63ba317144d1a01599b0fefeef580aeac/third_party/WebKit/Source/platform/audio/FFTFrame.h
[modify] https://crrev.com/4f6f6ba63ba317144d1a01599b0fefeef580aeac/third_party/WebKit/Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp

Status: Verified (was: Started)
There is not any unneeded const casts under third_party/WebKit/Source/platform/audio anymore.

Sign in to add a comment