New issue
Advanced search Search tips

Issue 822717 link

Starred by 1 user
Status: Fixed
Owner:
mmenke@chromium.org
Closed: Mar 2018
Cc:
eladalon@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Incorrect documentation on UploadDataStream::ResetInternal

Project Member Reported by eladalon@chromium.org, Mar 16 2018 
The documentation says "Guaranteed to be called before all but the first call to InitInternal." However, the function is actually also called before the first call to InitInternal.

Comment 1 by mmenke@chromium.org, Mar 16 2018

Cc: mmenke@chromium.org
Components: Internals>Network
Owner: ----
Status: Available (was: Assigned)
That's likely a consumer being weird.  I don't consider this to be of sufficient concern to be worth investigating.

Comment 2 by eladalon@chromium.org, Mar 16 2018 

That's in the superclass's code:
UploadDataStream::Init() calls UploadDataStream::Reset(), which calls ResetInternal(), and then, back inside UploadDataStream::Init(), UploadDataStream::InitInternal() is called.

Comment 3 by mmenke@chromium.org, Mar 16 2018

Cc: -mmenke@chromium.org
Owner: mmenke@chromium.org
Oops, you're right!  I checked, and somehow managed to miss it.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9991f9b197a4cfc5e8f4fb4337fcea0bef78c54

commit d9991f9b197a4cfc5e8f4fb4337fcea0bef78c54
Author: Matt Menke <mmenke@chromium.org>
Date: Fri Mar 23 20:16:33 2018

UploadDataStream:  Update ResetInternal() documentation.

NOTRY=true

Bug:  822717 
Change-Id: I21cd2bed496cef2d8e94d1eebc7354cfa5b90ddd
Reviewed-on: https://chromium-review.googlesource.com/978385
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545565}
[modify] https://crrev.com/d9991f9b197a4cfc5e8f4fb4337fcea0bef78c54/net/base/upload_data_stream.h

Comment 5 by mmenke@chromium.org, Mar 23 2018

Status: Fixed (was: Available)
►

Sign in to add a comment