New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822712 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Create new project to host webrtc apm code

Project Member Reported by hychao@chromium.org, Mar 16 2018

Issue description

Per  issue 710465 , we would like to create a external project to host modified WebRTC APM code, at src/third_party/webrtc-apm
 

Comment 1 by hychao@chromium.org, Mar 16 2018

Owner: dshi@chromium.org
Status: Assigned (was: Available)
Hi Dan, can you or someone from infra team help with this? thanks!

Comment 2 by dshi@chromium.org, Mar 16 2018

Owner: ayatane@chromium.org
Assign to infra deputy
Labels: Hotlist-Deputy
Owner: akes...@chromium.org
I'm pretty sure I don't have "Create Project" permissions, since I don't have that menu according to the docs.
Owner: ayatane@chromium.org
Never mind, I found it, under the "Browse" link in Gerrit, of all places.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/163743483ae0a2247bb8c5f2e26342faa6431cfc

commit 163743483ae0a2247bb8c5f2e26342faa6431cfc
Author: Allen Li <ayatane@chromium.org>
Date: Sat Mar 17 01:31:30 2018

Add chromiumos/third_party/webrtc-apm

BUG= chromium:822712 
TEST=None

Change-Id: I4a7ed403a06e1116e109a8543d25c822f6cec812
Reviewed-on: https://chromium-review.googlesource.com/967222
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/163743483ae0a2247bb8c5f2e26342faa6431cfc/full.xml

Hi Ayatane, should the project access be set to inherit from chromiumos ?

Currently it is:
https://chromium-review.googlesource.com/#/admin/projects/chromiumos/third_party/webrtc-apm,access

Rights Inherit From: All-Projects

Other projects,e.g., adhd has this access setting:
https://chromium-review.googlesource.com/#/admin/projects/chromiumos/third_party/adhd,access

Rights Inherit From: chromiumos


I have created a README CL

https://chromium-review.googlesource.com/#/c/chromiumos/third_party/webrtc-apm/+/967701/

But I don't have +2 permission to it. So I guess it might be access issue.
I have created the CL to change access:

https://chromium-review.googlesource.com/#/c/chromiumos/third_party/webrtc-apm/+/967582/

Please let me know how to proceed.

Thanks!
Owner: akes...@chromium.org
Oops, I don't have +2 on it either.  I feel like Gerrit should warn if you try to create a project that you can't edit.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/015bb9eb40fa6ed03d1b4647ad17408c50d617ab

commit 015bb9eb40fa6ed03d1b4647ad17408c50d617ab
Author: Allen Li <ayatane@chromium.org>
Date: Mon Mar 19 21:19:11 2018

Hi akashet,
Can you help give the correct permission to this new project?
irony: if initial project has ACLs set correctly, you can't fix them w/out the ACLs being set correctly ;)
https://chromium-review.googlesource.com/972427
Status: Fixed (was: Assigned)
fixed

Sign in to add a comment