New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822670 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Non-Regression: Proxy connection type is changing when Automatic proxy configuration type is selected In proxy settings overlay

Project Member Reported by kebalaji@chromium.org, Mar 16 2018

Issue description

Chrome Version:67.0.3369.0/10493.0.0 dev channel Jerry,Peppy,Candy
OS: Chrome OS

What steps will reproduce the problem?
(1)Recover build>> In OOBE screen, connect to a Network 
(2)Click on Proxy settings>> Now change the Proxy connection type to Automatic proxy configuration and wait for some 5 secs and observe

Actual: When selecting  Automatic proxy configuration type, within 5 secs its getting changed to the previously selected connection type (Refer video)

Expected: Proxy connection type should stay as Automatic proxy configuration type when selected

This is a Non-Regression issue seen from M62

NOTE: Issue is seen on M63,M64, M65 and M66 also

@Stevenjb: Please confirm the issue
 
ActualProxy.mp4
7.5 MB View Download
Labels: Needs-Feedback
It does not look like an automatic proxy configuration URL is available, possibly Shill is setting it back to 'direct' in that case. Please test other networks and provide a feedback report.

Labels: -Needs-Feedback
C#1->>

Issue is not only seen for Direct Internet connection option but also seen for other options ie.,
1. First select Web proxy autodiscovery option 
2. Now change it to  Automatic proxy configuration and wait for some 5 secs and observe it is changing back to Web proxy autodiscovery option 

Thanks!
 
Labels: -Pri-2 -M-67 M-66 Pri-1
Status: Started (was: Assigned)
Ahh. I see.

We do not actually change the setting until a URL is entered. In the meanwhile, if an update is received (e.g. when the signal strength is updated), we overwrite the dropdown selection.

This makes it pretty difficult to correctly change the setting, so escalating to a P1.

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1986382b3a837039086e2e77effd890062fe0883

commit 1986382b3a837039086e2e77effd890062fe0883
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Mar 22 02:32:09 2018

Proxy config: Correctly set autoconfiguration URL

This CL:
* Delays setting Proxy.Type to PAC unless a PAC value is set.
* Sets proxyModified_ = true otherwise so that the type is not
  overridden on an update.
* Focus the appropriate input field when the proxy type changes.

Bug:  822670 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0e9a68fc8982d2286e144e57dfe14dc61fa84b1b
Reviewed-on: https://chromium-review.googlesource.com/974119
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544955}
[modify] https://crrev.com/1986382b3a837039086e2e77effd890062fe0883/ui/webui/resources/cr_components/chromeos/network/network_proxy.html
[modify] https://crrev.com/1986382b3a837039086e2e77effd890062fe0883/ui/webui/resources/cr_components/chromeos/network/network_proxy.js
[modify] https://crrev.com/1986382b3a837039086e2e77effd890062fe0883/ui/webui/resources/cr_components/chromeos/network/network_proxy_input.js

Labels: Merge-Request-66
Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 23 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-66 Merge-Approved-66
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 26 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fc58b7e579444f970fb018c3d9f77aebcdd4d97

commit 9fc58b7e579444f970fb018c3d9f77aebcdd4d97
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Mar 26 17:31:00 2018

Proxy config: Correctly set autoconfiguration URL

This CL:
* Delays setting Proxy.Type to PAC unless a PAC value is set.
* Sets proxyModified_ = true otherwise so that the type is not
  overridden on an update.
* Focus the appropriate input field when the proxy type changes.

TBR=stevenjb@chromium.org

(cherry picked from commit 1986382b3a837039086e2e77effd890062fe0883)

Bug:  822670 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0e9a68fc8982d2286e144e57dfe14dc61fa84b1b
Reviewed-on: https://chromium-review.googlesource.com/974119
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#544955}
Reviewed-on: https://chromium-review.googlesource.com/981078
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#439}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/9fc58b7e579444f970fb018c3d9f77aebcdd4d97/ui/webui/resources/cr_components/chromeos/network/network_proxy.html
[modify] https://crrev.com/9fc58b7e579444f970fb018c3d9f77aebcdd4d97/ui/webui/resources/cr_components/chromeos/network/network_proxy.js
[modify] https://crrev.com/9fc58b7e579444f970fb018c3d9f77aebcdd4d97/ui/webui/resources/cr_components/chromeos/network/network_proxy_input.js

Sign in to add a comment