MacViews: Bubbles have two dismiss-on-right-click monitors in BridgedNativeWidget |
||||
Issue descriptionChrome Version : 65.0.3325.146 One was added in r498221, but it was incomplete. I refactored out the one that our Cocoa code was using and incorporated it in r520367. I think most of r498221 is obsolete now and can be reverted (except for its test! which hopefully still passes... [or maybe it needs some to plumb in more of BubbleDialogDelegateView])
,
Mar 27 2018
,
Mar 29 2018
** Bulk Edit ** FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.
,
Mar 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/295921cb127878b5625eaf2ddf2f2d3dcf22c89b commit 295921cb127878b5625eaf2ddf2f2d3dcf22c89b Author: Wei Li <weili@chromium.org> Date: Fri Mar 30 17:12:15 2018 Remove dismiss-on-right-click in BridgedNativeWidget To dismiss bubble on right click, ui::BubbleCloser is now used for both Cocoa and Views. So the one in BridgedNativeWidget is no longer needed. Remove it. BUG= 822664 Change-Id: Ic707a6d27b4ed68076f596dfe542f52a38dc53b8 Reviewed-on: https://chromium-review.googlesource.com/985430 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#547193} [modify] https://crrev.com/295921cb127878b5625eaf2ddf2f2d3dcf22c89b/ui/views/cocoa/bridged_native_widget.h [modify] https://crrev.com/295921cb127878b5625eaf2ddf2f2d3dcf22c89b/ui/views/cocoa/bridged_native_widget.mm
,
Mar 30 2018
,
Apr 2 2018
Verified the issue with below steps. 1. Enabled Mac views with flag --enable-features=ViewsBrowserWindows and opened bookmyshow which in turn opens Location bubble. 2. Now right clicked inside page and observed no dismissal of bubble. Hence checked the issue on latest canary 67.0.3386.0 with steps. @weili: Please check the steps and let us know if we miss anything. Please provide written steps to verify the issue from TE end.
,
Apr 3 2018
#c6: permissions prompts are a persistent bubble type, so that behavior is correct. There's a repro on Issue 692896 , which we want to ensure didn't regress (I checked - I think it's fine). |
||||
►
Sign in to add a comment |
||||
Comment 1 by ellyjo...@chromium.org
, Mar 26 2018Owner: weili@chromium.org
Status: Assigned (was: Available)