New issue
Advanced search Search tips

Issue 822640 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Mar 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Reset settings overlay doesn't closes after clicking on back navigation button.

Reported by vku...@etouch.net, Mar 16 2018 
Chrome Version: 67.0.3371.0 (Official Build) Revision 497c718be40e845d85a70a9b3a01c6f1ebe44efc-refs/heads/master@{#543278} (32/64-bit) 
OS: Win(7,8,8.1,10),Mac(10.12.6,10.13.1,10.13.4) & Linux(14.04 LTS)

What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://settings/
(2)Click on advanced > click on reset such that overlay appears
(3)Now press back navigation button and observe

Actual: Reset settings overlay doesn't closes after clicking on back navigation button.

Expected: Reset settings overlay should close after clicking on back navigation button.

This is a regression issue broken in 'M64' and below is the manual bisect info
Good Build: 64.0.3271.0 (Revision:517251)
Bad Build:  64.0.3272.0 (Revision:517671)
Actual_settings.mp4
564 KB View Download
Expected_settings.mp4
448 KB View Download

Comment 1 by vku...@etouch.net, Mar 16 2018

Labels: hasbisect-per-revision Target-67 RegressedIn-64 Target-66 FoundIn-66 FoundIn-67 Target-65 FoundIn-65
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 543546 (known good), but no later than 543547 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/20f412dccbcc33f74b2c83c5fb64ea598d8401b2..b573bfa09c1325089e43e2390e70e093bac65803

Suspect: https://chromium.googlesource.com/chromium/src/+/b573bfa09c1325089e43e2390e70e093bac65803

Comment 2 by dpa...@chromium.org, Mar 16 2018 

The "expected" video, seems identical to the "actual" one. I am a bit confused.

Comment 3 by dpa...@chromium.org, Mar 16 2018

Labels: -Pri-1 Pri-2

Comment 4 by dpa...@chromium.org, Mar 16 2018

Status: Started (was: Assigned)
I was able to reproduce this locally. So I just think that the "expected" video is wrong, but the bug is still valid.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56aa5a782d2f8935249c764864a6fec071339adc

commit 56aa5a782d2f8935249c764864a6fec071339adc
Author: dpapad <dpapad@chromium.org>
Date: Mon Mar 19 23:52:37 2018

Settings WebUI: Dismiss "reset profile" dialog on back navigation.

Bug:  822640 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I34936fa59d5f930250a12619674f4be1ee5c767c
Reviewed-on: https://chromium-review.googlesource.com/966996
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544213}
[modify] https://crrev.com/56aa5a782d2f8935249c764864a6fec071339adc/chrome/browser/resources/settings/reset_page/compiled_resources2.gyp
[modify] https://crrev.com/56aa5a782d2f8935249c764864a6fec071339adc/chrome/browser/resources/settings/reset_page/reset_page.js
[modify] https://crrev.com/56aa5a782d2f8935249c764864a6fec071339adc/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
[modify] https://crrev.com/56aa5a782d2f8935249c764864a6fec071339adc/chrome/test/data/webui/settings/reset_page_test.js

Comment 6 by dpa...@chromium.org, Mar 20 2018

Status: Fixed (was: Started)
►

Sign in to add a comment