"ProcessManagerBrowserTest.NestedURLNavigationsViaProxyBlocked" is flaky |
|||||||||
Issue description"ProcessManagerBrowserTest.NestedURLNavigationsViaProxyBlocked" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySAsSBUZsYWtlIj1Qcm9jZXNzTWFuYWdlckJyb3dzZXJUZXN0Lk5lc3RlZFVSTE5hdmlnYXRpb25zVmlhUHJveHlCbG9ja2VkDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Mar 16 2018
[Build sheriff] Will proceed to revert the CL.
,
Mar 16 2018
Nick will take a quick look to see if we can fix the test. This CL is an important security fix, so we're hoping to avoid reverting it if possible.
,
Mar 16 2018
Sounds good, will let nick@ work on a fix, failing which, if it's not ok to revert, we can probably disable the test temporarily.
,
Mar 16 2018
Thanks! I've got a disable CL with try jobs started in case we don't find a quick fix: https://chromium-review.googlesource.com/c/chromium/src/+/967062
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/246cb9ee5371e72f652743144f9f7a5683218ccd commit 246cb9ee5371e72f652743144f9f7a5683218ccd Author: Charlie Reis <creis@chromium.org> Date: Fri Mar 16 20:05:23 2018 Disable flaky NestedURLNavigationsViaProxyBlocked test. BUG= 822635 Change-Id: Ic3966f502e8d8ee5937a96b1a006f62c73d70230 Reviewed-on: https://chromium-review.googlesource.com/967062 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#543797} [modify] https://crrev.com/246cb9ee5371e72f652743144f9f7a5683218ccd/chrome/browser/extensions/process_manager_browsertest.cc
,
Mar 16 2018
Thanks creis@.
,
Mar 16 2018
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac31d43d24d2e855e73c588fb9705904276da91e commit ac31d43d24d2e855e73c588fb9705904276da91e Author: Nick Carter <nick@chromium.org> Date: Fri Mar 16 23:38:35 2018 Fix test flake in ProcessManagerBrowserTest.NestedURLNavigationsViaProxyBlocked Cause of flake was confirmed by adding a slow unload handler to |popup|. This fixes it. Bug: 821596 , 822635 Change-Id: I602c98a0fb37f9951cc85fb9d886616bb22e8b42 Reviewed-on: https://chromium-review.googlesource.com/967352 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#543870} [modify] https://crrev.com/ac31d43d24d2e855e73c588fb9705904276da91e/chrome/browser/extensions/process_manager_browsertest.cc
,
Mar 17 2018
,
Apr 2 2018
Requesting merge for M66 of CLs in #6 and #9. These are test-only changes, but merging them is necessary so that r547218 (which is merge-requested in bug 821586 ) applies cleanly.
,
Apr 2 2018
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 3 2018
Approving merge to M66. Branch:3359
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bd04e500d53ac2c60bf02ed4d39c746fbc02e75 commit 8bd04e500d53ac2c60bf02ed4d39c746fbc02e75 Author: Charlie Reis <creis@chromium.org> Date: Tue Apr 03 19:46:42 2018 Disable flaky NestedURLNavigationsViaProxyBlocked test. BUG= 822635 Change-Id: Ic3966f502e8d8ee5937a96b1a006f62c73d70230 Reviewed-on: https://chromium-review.googlesource.com/967062 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#543797}(cherry picked from commit 246cb9ee5371e72f652743144f9f7a5683218ccd) Reviewed-on: https://chromium-review.googlesource.com/990452 Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#559} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/8bd04e500d53ac2c60bf02ed4d39c746fbc02e75/chrome/browser/extensions/process_manager_browsertest.cc
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/acc0f30fa74a040b656b67450726efb866bbd218 commit acc0f30fa74a040b656b67450726efb866bbd218 Author: Nick Carter <nick@chromium.org> Date: Tue Apr 03 19:47:37 2018 Fix test flake in ProcessManagerBrowserTest.NestedURLNavigationsViaProxyBlocked Cause of flake was confirmed by adding a slow unload handler to |popup|. This fixes it. Bug: 821596 , 822635 Change-Id: I602c98a0fb37f9951cc85fb9d886616bb22e8b42 Reviewed-on: https://chromium-review.googlesource.com/967352 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Nick Carter <nick@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#543870}(cherry picked from commit ac31d43d24d2e855e73c588fb9705904276da91e) Reviewed-on: https://chromium-review.googlesource.com/990453 Reviewed-by: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#560} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/acc0f30fa74a040b656b67450726efb866bbd218/chrome/browser/extensions/process_manager_browsertest.cc
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b85d4231b2f726c765750ba2918e3bc6f5d96981 commit b85d4231b2f726c765750ba2918e3bc6f5d96981 Author: Nick Carter <nick@chromium.org> Date: Tue Apr 03 19:53:37 2018 Revert "Disable flaky NestedURLNavigationsViaProxyBlocked test." This reverts commit 8bd04e500d53ac2c60bf02ed4d39c746fbc02e75. Reason for revert: merged fix for flakiness Original change's description: > Disable flaky NestedURLNavigationsViaProxyBlocked test. > > BUG= 822635 > > Change-Id: Ic3966f502e8d8ee5937a96b1a006f62c73d70230 > Reviewed-on: https://chromium-review.googlesource.com/967062 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Charlie Reis <creis@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#543797}(cherry picked from commit 246cb9ee5371e72f652743144f9f7a5683218ccd) > Reviewed-on: https://chromium-review.googlesource.com/990452 > Reviewed-by: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/branch-heads/3359@{#559} > Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} TBR=creis@chromium.org,nick@chromium.org Change-Id: I866acc05663b10ea64709ed29d93cd95535cb042 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 822635 Reviewed-on: https://chromium-review.googlesource.com/993594 Reviewed-by: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#561} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/b85d4231b2f726c765750ba2918e3bc6f5d96981/chrome/browser/extensions/process_manager_browsertest.cc |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bcwh...@chromium.org
, Mar 16 2018Owner: nick@chromium.org
Status: Assigned (was: Untriaged)