components_perftests failing on chromium.win/Win7 Tests (dbg)(1) |
||||||
Issue descriptioncomponents_perftests started failing from https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/66906 See the history at https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29?numbuilds=200 Off the top of my head, the following patch seems related (not for sure). https://chromium.googlesource.com/chromium/src/+/b73107cb0226c61a1afae2457f2a3988c1b18c0b csharrison@, could you take a look? If it's not related to your patch, then could you triage this issue?
,
Mar 16 2018
I think the V4 Stress Test does too much work for the debug build my take from the debug log is that we time out during tear down. This involves deallocating ~72 mb of strings. I might be able to speed things up, or just disable the test on dbg builds.
,
Mar 16 2018
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4032b171ce2c4de0b2c2fdfbecdc9649708d08b commit d4032b171ce2c4de0b2c2fdfbecdc9649708d08b Author: Charles Harrison <csharrison@chromium.org> Date: Fri Mar 16 20:00:38 2018 [safe-browsing] Make the perftest less allocate-y This CL makes the V4 Store perftest a bit faster by: 1. Using a smaller # of hashes in debug builds 2. Using one big string instead of a vector of full hashes, to avoid allocating and de-allocating many small strings. To get this working, needed to slightly modify V4Store to allow querying by StringPiece. (2) improved local performance on my release build by 25-30% Bug: 822624 Change-Id: I646af2b0ccfb6447ccbb94ce68b661bd235587d1 Reviewed-on: https://chromium-review.googlesource.com/965931 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#543796} [modify] https://crrev.com/d4032b171ce2c4de0b2c2fdfbecdc9649708d08b/components/safe_browsing/db/v4_store.cc [modify] https://crrev.com/d4032b171ce2c4de0b2c2fdfbecdc9649708d08b/components/safe_browsing/db/v4_store.h [modify] https://crrev.com/d4032b171ce2c4de0b2c2fdfbecdc9649708d08b/components/safe_browsing/db/v4_store_perftest.cc
,
Mar 16 2018
Should be fixed
,
Mar 16 2018
,
Mar 20 2018
Looks like HQPPerfTest tests are timing out too. I'm looking into it.
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f40f8584b5b11fe2b36ecdeefbc144a18a60b52 commit 8f40f8584b5b11fe2b36ecdeefbc144a18a60b52 Author: Charles Harrison <csharrison@chromium.org> Date: Wed Mar 21 20:04:11 2018 HQPPerfTest: speed up test on dbg builds Bug: 822624 Change-Id: I1ffee8e38bee2e016dc6beddd3eb05464def68a8 Reviewed-on: https://chromium-review.googlesource.com/966494 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#544812} [modify] https://crrev.com/8f40f8584b5b11fe2b36ecdeefbc144a18a60b52/components/omnibox/browser/history_quick_provider_performance_unittest.cc
,
Mar 21 2018
should be fixed... once and for all! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by yukishiino@chromium.org
, Mar 16 2018