FR: Show visual feedback on hover/click/tap with new media controls |
|||||||
Issue descriptionIn https://plus.google.com/+FrancoisBeaufort/posts/iSC8kJkaQ6h, people have asked for visual feedback on hover/click/tap with new media controls. That was always the greatest accessibility issue with the previous default audio/video controls for me. Is this something we'd like to introduce as part of the redesign with new media controls?
,
Mar 19 2018
steimel@ and I have been fine tuning animation sequencing for show/hide https://docs.google.com/presentation/d/1Xwu6nvCoxEIjuIdGYt9DRPBHqEX3QQkpQluHcJazCsE/edit#slide=id.g31e26aaa5b_0_15 Do you think this approach fully addresses the G+ feedback?
,
Mar 20 2018
It looks fine to me but I'll ping people when they can try it out. Thanks!
,
Mar 23 2018
,
Mar 23 2018
Isn't the feature request more related to a feedback when something is hovered? I believe that VR asked for the same thing.
,
Mar 28 2018
I see the nuance now -- the show/hide on hover will happen for the full control set on desktop, but IIUC the VR ask pertains to icon level hovers and clicked states. I've added it to the punch list for tracking. (tracking here https://docs.google.com/spreadsheets/d/1llrhb84lSIY7m_uDXnUfIDFY3x1fN9INNfihqdqgcrE/edit#gid=0&range=A29 )
,
Mar 28 2018
,
Apr 9 2018
Assigning to amyroberts@ for specs.
,
May 11 2018
,
May 23 2018
specs: https://docs.google.com/presentation/d/1crVckjRA7LZ2S-SPuO8zXMQPw_uZwC0-eBhZ5EEumCw/edit#slide=id.g3b0a42aa38_0_171
,
May 23 2018
,
Jun 26 2018
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fdc54a404d0a305f3ef5a53942e2b1684f74cbe commit 1fdc54a404d0a305f3ef5a53942e2b1684f74cbe Author: Jazz Xu <jazzhsu@chromium.org> Date: Wed Dec 19 00:10:59 2018 [Media Controls] Show visual feedback on hover This CL achieved a hover effect for the input buttons. Because we want the tap target to stay 48x48 while having the hover background 36x36, we attached div to each input button (play/pause, fullscreen, mute, overflow) to achieve the hover effect. Bug: 822622 Change-Id: I14a1ae156b76b1933cb2102abf656032876b2118 Reviewed-on: https://chromium-review.googlesource.com/c/1331867 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#617681} [modify] https://crrev.com/1fdc54a404d0a305f3ef5a53942e2b1684f74cbe/content/test/data/accessibility/html/audio-expected-auralinux.txt [modify] https://crrev.com/1fdc54a404d0a305f3ef5a53942e2b1684f74cbe/content/test/data/accessibility/html/source-expected-auralinux.txt [modify] https://crrev.com/1fdc54a404d0a305f3ef5a53942e2b1684f74cbe/third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.cc [modify] https://crrev.com/1fdc54a404d0a305f3ef5a53942e2b1684f74cbe/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc [modify] https://crrev.com/1fdc54a404d0a305f3ef5a53942e2b1684f74cbe/third_party/blink/renderer/modules/media_controls/media_controls_impl.h [modify] https://crrev.com/1fdc54a404d0a305f3ef5a53942e2b1684f74cbe/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css [modify] https://crrev.com/1fdc54a404d0a305f3ef5a53942e2b1684f74cbe/third_party/blink/web_tests/media/controls/modern/video-tag-with-only-audio-looks-like-audio-tag.html |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by fbeaufort@chromium.org
, Mar 16 2018