"NetworkServiceRestartBrowserTest.BrowserIOSharedFactoryAfterStoragePartitionGone" is flaky |
||||
Issue description"NetworkServiceRestartBrowserTest.BrowserIOSharedFactoryAfterStoragePartitionGone" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWwsSBUZsYWtlIlBOZXR3b3JrU2VydmljZVJlc3RhcnRCcm93c2VyVGVzdC5Ccm93c2VySU9TaGFyZWRGYWN0b3J5QWZ0ZXJTdG9yYWdlUGFydGl0aW9uR29uZQw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Mar 16 2018
,
Mar 16 2018
[Build sheriff] Will proceed to disabling the test.
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7667979b0514c1ce96957df700fef3a90a53a28d commit 7667979b0514c1ce96957df700fef3a90a53a28d Author: Karan Bhatia <karandeepb@chromium.org> Date: Fri Mar 16 19:49:44 2018 Disable flaky NetworkServiceRestartBrowserTest.BrowserIOSharedFactoryAfterStoragePartitionGone. TBR=chongz@chromium.org, kinuko@chromium.org BUG= 822585 Change-Id: I926212903064753268cc217ab8ef3be4e9dfaf4c Reviewed-on: https://chromium-review.googlesource.com/967009 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543788} [modify] https://crrev.com/7667979b0514c1ce96957df700fef3a90a53a28d/content/browser/network_service_restart_browsertest.cc
,
Mar 16 2018
Failure log from Linux ASAN: [ RUN ] NetworkServiceRestartBrowserTest.BrowserIOSharedFactoryAfterStoragePartitionGone Xlib: extension "RANDR" missing on display ":99". DevTools listening on ws://127.0.0.1:56126/devtools/browser/0ca4fa93-cfad-4959-b898-006341f89a42 [7307:7307:0316/095945.519309:FATAL:weak_ptr.cc(20)] Check failed: sequence_checker_.CalledOnValidSequence() || HasOneRef(). WeakPtrs must be invalidated on the same sequenced thread. #0 0x00000562aaf1 (/b/s/w/ir/out/Release/content_browsertests+0x562aaf0) #1 0x00000eebe3ec (/b/s/w/ir/out/Release/content_browsertests+0xeebe3eb) #2 0x00000ef2af23 (/b/s/w/ir/out/Release/content_browsertests+0xef2af22) #3 0x00000ef4a9a0 (/b/s/w/ir/out/Release/content_browsertests+0xef4a99f) #4 0x00000ef4ae82 (/b/s/w/ir/out/Release/content_browsertests+0xef4ae81) #5 0x00000e135f33 (/b/s/w/ir/out/Release/content_browsertests+0xe135f32) #6 0x0000062e581e (/b/s/w/ir/out/Release/content_browsertests+0x62e581d) #7 0x0000062e7265 (/b/s/w/ir/out/Release/content_browsertests+0x62e7264) #8 0x00000e0eac42 (/b/s/w/ir/out/Release/content_browsertests+0xe0eac41) #9 0x00000e37109b (/b/s/w/ir/out/Release/content_browsertests+0xe37109a) #10 0x00000c2542d5 (/b/s/w/ir/out/Release/content_browsertests+0xc2542d4) #11 0x00000d370078 (/b/s/w/ir/out/Release/content_browsertests+0xd370077) #12 0x00000c250099 (/b/s/w/ir/out/Release/content_browsertests+0xc250098) #13 0x00000c25e751 (/b/s/w/ir/out/Release/content_browsertests+0xc25e750) #14 0x00000e36f493 (/b/s/w/ir/out/Release/content_browsertests+0xe36f492) #15 0x00000e27deb2 (/b/s/w/ir/out/Release/content_browsertests+0xe27deb1) #16 0x00000bea5b65 (/b/s/w/ir/out/Release/content_browsertests+0xbea5b64) #17 0x00000bea9196 (/b/s/w/ir/out/Release/content_browsertests+0xbea9195) #18 0x000013588aa3 (/b/s/w/ir/out/Release/content_browsertests+0x13588aa2) #19 0x0000096579e9 (/b/s/w/ir/out/Release/content_browsertests+0x96579e8) #20 0x00000e0e986c (/b/s/w/ir/out/Release/content_browsertests+0xe0e986b) #21 0x00000e0c2287 (/b/s/w/ir/out/Release/content_browsertests+0xe0c2286) #22 0x000008592a1d (/b/s/w/ir/out/Release/content_browsertests+0x8592a1c) #23 0x000008594ca5 (/b/s/w/ir/out/Release/content_browsertests+0x8594ca4) #24 0x000008596057 (/b/s/w/ir/out/Release/content_browsertests+0x8596056) #25 0x0000085bbd27 (/b/s/w/ir/out/Release/content_browsertests+0x85bbd26) #26 0x0000085baf74 (/b/s/w/ir/out/Release/content_browsertests+0x85baf73) #27 0x00000e1e1209 (/b/s/w/ir/out/Release/content_browsertests+0xe1e1208) #28 0x00000e0d0978 (/b/s/w/ir/out/Release/content_browsertests+0xe0d0977) #29 0x00000e15d31d (/b/s/w/ir/out/Release/content_browsertests+0xe15d31c) #30 0x00000e0d07f3 (/b/s/w/ir/out/Release/content_browsertests+0xe0d07f2) #31 0x7f0956cb8f45 (/lib/x86_64-linux-gnu/libc-2.19.so+0x21f44) #32 0x0000055df02a (/b/s/w/ir/out/Release/content_browsertests+0x55df029)
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f85721835d02da491effcb4483c249b639d4e9d8 commit f85721835d02da491effcb4483c249b639d4e9d8 Author: Chong Zhang <chongz@chromium.org> Date: Fri Mar 16 23:10:18 2018 Fix flaky NetworkServiceRestartBrowserTest.BrowserIOSharedFactoryAfterStoragePartitionGone This test is flaky on Linux ASAN and Android, sample failure from Android: ``` logging::LogMessage::~LogMessage() base::internal::WeakReference::Flag::Invalidate() base::internal::WeakReferenceOwner::~WeakReferenceOwner() content::SimpleURLLoaderTestHelper::~SimpleURLLoaderTestHelper() content::(anonymous namespace)::LoadBasicRequestOnIOThread(network::mojom::URLLoaderFactory*, GURL const&) content::NetworkServiceRestartBrowserTest_BrowserIOSharedFactoryAfterStoragePartitionGone_Test::RunTestOnMainThread() ``` This CL makes sure that |simple_loader_helper.GetCallback()| was only accessed on UI thread (where |simple_loader_helper| lives). (I cannot reproduce the flakiness locally, will see if this fixes the issue.) Bug: 822585 Change-Id: I74de7dd4708f20dcb2f0145228d6de19ac7f15b3 Reviewed-on: https://chromium-review.googlesource.com/966985 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#543859} [modify] https://crrev.com/f85721835d02da491effcb4483c249b639d4e9d8/content/browser/network_service_restart_browsertest.cc [modify] https://crrev.com/f85721835d02da491effcb4483c249b639d4e9d8/content/public/test/simple_url_loader_test_helper.cc [modify] https://crrev.com/f85721835d02da491effcb4483c249b639d4e9d8/content/public/test/simple_url_loader_test_helper.h
,
Mar 19 2018
The test is no longer flaky. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bcwh...@chromium.org
, Mar 16 2018Status: Assigned (was: Untriaged)