Regression: 'X' icon is misplaced on chrome://extensions/shortcuts.
Reported by
aiman.an...@etouch.net,
Mar 16 2018
|
|||
Issue descriptionChrome Version: 67.0.3371.0 (Official Build) Revision 497c718be40e845d85a70a9b3a01c6f1ebe44efc-refs/heads/master@{#543278} (32/64 Bit). OS: Win(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4) and Linux(14.04 LTS). Test URL: https://chrome.google.com/webstore/detail/adobe-acrobat/efaidnbmnnnibpcajpcglclefindmkaj?utm_source=chrome-ntp-icon What steps will reproduce the problem? 1. Launch chrome, navigate to the above URL and download the extension, navigate to chrome://extensions/shortcuts 2. Observe 'X' icon for added extension under extensions-shortcuts. Actual: 'X' icon is misplaced for extensions having shortcuts feature. Expected: 'X' icon should not be misplaced. This is a regression issue, broken in M-67 series, Using the per-revision bisect providing the bisect results, Good Build:67.0.3368.0(Revision:542341) Bad Build:67.0.3369.0(Revision:542817) You are probably looking for a change made after 542361 (known good), but no later than 542362 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/feb3b5d8fc0436f4ae83736f450544142e9a21f1..b6477fef9acbe00a3e8b58b6963b518b57575ed3 Suspect: https://chromium.googlesource.com/chromium/src/+/b6477fef9acbe00a3e8b58b6963b518b57575ed3 hcarmona@:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Issue is only reproducible for extensions having keyboard shortcut feature. 2. On Mac and Linux OS you need to add keyboard shortcut (e.g CTRL+A / CMD+A) to view 'X' Icon. 3. Issue is also reproducible on latest Canary build #67.0.3372.0. Thank You!
,
Mar 22 2018
+screenshot + CL: https://crrev.com/c/976383
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/055ba4217f31491ece7bcd90826569aa5231c0f8 commit 055ba4217f31491ece7bcd90826569aa5231c0f8 Author: Hector Carmona <hcarmona@chromium.org> Date: Fri Mar 23 18:51:05 2018 MD Extensions: Fix X button styling This was missed as part of the v2 paper-icon-button-light migration. Bug: 822573 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifeacc6ca78efb16df0de851698bff71d11fac5b5 Reviewed-on: https://chromium-review.googlesource.com/976383 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#545538} [modify] https://crrev.com/055ba4217f31491ece7bcd90826569aa5231c0f8/chrome/browser/resources/md_extensions/shortcut_input.html
,
Mar 23 2018
,
Mar 27 2018
Update : Retested above issue on Windows(7,8,8.1,10) Linux(14.04 LTS )and Mac(10.12.6, 10.13.1, 10.13.4) OS using latest Canary #67.0.3381.0 and issue is fixed. Now, 'X' icon on chrome://extensions/shortcuts does not misplace. Kindly review the attached screen-cast. Thank you! |
|||
►
Sign in to add a comment |
|||
Comment 1 by hcarmona@chromium.org
, Mar 22 2018