New issue
Advanced search Search tips

Issue 822559 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

hterm: double click won't expand selection unless "copy-on-select" is on

Reported by johnl...@gmail.com, Mar 16 2018

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 10032.76.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.150 Safari/537.36
Platform: 61.4.54 (Developer Build - neverware) developer-build chromeover64

Steps to reproduce the problem:
1. Turn off the option "copy-on-select".
2. Double click on a file path (e.g. /home/johnlinp)

What is the expected behavior?
The selection should expand to the whole path.

What went wrong?
The selection doesn't expand to the whole path.

WebStore page: https://chrome.google.com/webstore/detail/secure-shell/pnhechapfaindjhompbnflcldabbghjo

Did this work before? N/A 

Chrome version: 63.0.3239.150  Channel: n/a
OS Version: 10032.76.0
Flash Version:
 

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/2aad22ec6844f0523f84feaf4186138fc6a5c992

commit 2aad22ec6844f0523f84feaf4186138fc6a5c992
Author: John Lin <johnlinp@gmail.com>
Date: Sat Mar 17 04:12:08 2018

hterm: double click should expand selection whether "copy-on-select" is on or off

BUG= chromium:822559 

Change-Id: Ie7681f735a6c230512dcc68fe384f5dd261c522d
Reviewed-on: https://chromium-review.googlesource.com/965728
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: John Lin <johnlinp@gmail.com>

[modify] https://crrev.com/2aad22ec6844f0523f84feaf4186138fc6a5c992/hterm/js/hterm_terminal.js

Comment 3 by vapier@chromium.org, Mar 17 2018

Status: Fixed (was: Available)

Sign in to add a comment