Issue metadata
Sign in to add a comment
|
PepperContentSettingsSpecialCasesJavaScriptBlockedTests fail when PersistentClientHints feature is enabled |
||||||||||||||||||||||
Issue descriptionPepperContentSettingsSpecialCasesPluginsBlockedTest.Flash and PepperContentSettingsSpecialCasesPluginsBlockedTest.NaCl tests fail when PersistentClientHints feature in Blink is enabled. These tests make an assumption that no other code in Chrome is querying the status of the JavaScript content setting. ClientHintsPersistent feature breaks this assumption since it queries the status of JavaScript content setting on every page load. When JavaScript is blocked, this results in tab_settings->IsContentBlocked(CONTENT_SETTINGS_TYPE_JAVASCRIPT) always returning true. This interferes with the correctness of these tests.
,
Mar 19 2018
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c211d8be5dd5da77ade1e6ff092f96478347a93f commit c211d8be5dd5da77ade1e6ff092f96478347a93f Author: Tarun Bansal <tbansal@chromium.org> Date: Mon Mar 19 19:21:58 2018 Add a method to check Script settings without notifying client Add a method in FrameFetchContext that can be used to check if JavaScript is allowed. This method does not notify the ContentSettingsClient when the JavaScript is blocked. The method is used by Client hints to check if JavaScript is allowed. Bug: 822553 Change-Id: I775af88099c3973f85e3c7306c1debd27282a9af Reviewed-on: https://chromium-review.googlesource.com/967565 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#544109} [modify] https://crrev.com/c211d8be5dd5da77ade1e6ff092f96478347a93f/chrome/browser/client_hints/client_hints_browsertest.cc [modify] https://crrev.com/c211d8be5dd5da77ade1e6ff092f96478347a93f/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/c211d8be5dd5da77ade1e6ff092f96478347a93f/third_party/WebKit/Source/core/loader/FrameFetchContext.h
,
Mar 20 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by raymes@chromium.org
, Mar 19 2018Status: Assigned (was: Untriaged)