New issue
Advanced search Search tips

Issue 822517 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 648042



Sign in to add a comment

Move ChromeOS Fuzzer Builds to Their Own GCS Bucket

Project Member Reported by metzman@chromium.org, Mar 16 2018

Issue description

Please make the ChromeOS build bots upload new fuzzing builds to gs://chromeos-fuzzing-artifacts/libfuzzer-asan instead of gs://chromeos-image-archive/amd64-generic-fuzzer/

This will make it less dangerous to fix issues with build uploads.
 
Labels: -Type-Bug Type-Feature
Components: Infra>Client>ChromeOS
This was discussed as the best way to solve issues with a variety of build artifact requirements, especially preserving them for long than most ChromeOS artifacts.

gs://chromeos-fuzzing-artifacts/ has been created with default permissions. I believe this is correct for this case.
Blocking: 648042
We should have a README in that bucket. What text is appropriate?

Maybe:

Build artifacts produced by ChromeOS fuzzing builders. They are here to preserve them for long term regression comparisons and testing.

Please contact <fuzzing-team-email> with details.

#5: SGTM.

You can use this for the last line:

Please contact chrome-security-bugs--@google.com for more details.
gsutil cp /tmp/README gs://chromeos-fuzzing-artifacts
Copying file:///tmp/README [Content-Type=application/octet-stream]...
AccessDeniedException: 403 aarya@google.com does not have storage.objects.create access to chromeos-fuzzing-artifacts/README.

Email address is wrong, it needs to have -- before @. i can add it, but looks like i cannot do this. Can you please make aarya@ and metzman@ the storage bucket owner.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/7f3fcf1e57bda9fd38b71435be3619e8357b4549

commit 7f3fcf1e57bda9fd38b71435be3619e8357b4549
Author: Don Garrett <dgarrett@google.com>
Date: Fri Mar 16 18:14:02 2018

chromeos_config: Move fuzzer builds into new bucket.

Move the fuzzer build artifacts into their own shiny new bucket. They
need a different retention policy, and want to make certain they are
kept distinct from tryjobs.

Almost force tryjob build artifacts back into the standard location.

BUG= chromium:822517 
TEST=run_tests

Change-Id: I87a05aa621492b4fdda642e7af925d08a6871d77
Reviewed-on: https://chromium-review.googlesource.com/965570
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/7f3fcf1e57bda9fd38b71435be3619e8357b4549/cbuildbot/config_dump.json
[modify] https://crrev.com/7f3fcf1e57bda9fd38b71435be3619e8357b4549/cbuildbot/chromeos_config.py

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5

commit b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Mar 16 22:50:01 2018

Roll src/third_party/chromite/ 3b75c9d82..3ad8f333d (31 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3b75c9d82ebf..3ad8f333d567

$ git log 3b75c9d82..3ad8f333d --date=short --no-merges --format='%ad %ae %s'
2018-03-16 dgarrett Revert "Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq.""
2018-03-16 dgarrett Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq."
2018-03-14 ayatane autotest-pre-cq: Remove builder and stage [2/2]
2018-03-16 dgarrett Revert "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq."
2018-03-15 dgarrett chromeos_config: Move fuzzer builds into new bucket.
2018-03-16 dgarrett Revert "commands: RunBranchUtilTest -> RunLocalTryjob"
2018-03-13 dgarrett pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq.
2018-02-07 dgarrett commands: RunBranchUtilTest -> RunLocalTryjob
2018-03-14 dgarrett cbuildbot_run: Switch more build links to Legoland.
2018-03-13 dgarrett swarming_lib: Remove SWARMING_TASK_ID from cmds.
2018-03-08 dgarrett moblab_vm_unitest: Fix lint issues.
2018-03-14 ihf chromeos_config: add more arcnext experimental coverage.
2018-03-14 ayatane autotest-pre-cq: Remove this [1/2]
2018-03-14 norvez chromeos_config: remove dead code
2018-03-09 dgarrett summarize_build_stats: Add blank line at beginning.
2018-01-09 dgarrett cros tryjob: Remove buildbot URL generation.
2017-09-14 craigb image_test: Remove check that kernel is not ELF.
2018-03-15 ihf Revert "chromeos_config: temporarily mark eve-arcnext-paladin experimental"
2018-03-15 ihf Revert "chromeos_config: temporarily experimental eve-arcnext-mst-android-pfq"
2018-03-13 lhchavez chromeos_config: Add betty-arcnext builder config
2018-03-13 achuith cbuildbot: Add missing files to index.
2018-03-13 akeshet completion_stages: add a has_important_slave metric to master completion
2018-03-13 dgarrett precq-launcher: Start using Legoland build details page.
2018-03-08 dgarrett chromite-pre-cq: Disable CidbIntegrationTest.
2018-03-14 akeshet chromeos_config: temporarily experimental eve-arcnext-mst-android-pfq
2018-03-13 akeshet chromeos_config: temporarily mark eve-arcnext-paladin experimental
2018-03-12 haddowk [chromite] Make guado_moblab important again
2018-03-13 chrome-bot Update config settings by config-updater.
2018-03-12 gmeinke chromium-config: replace cros_config_host_py in chromite
2018-03-12 yunlian Enable ThinLTO on all AMD64 boards.
2018-03-12 achuith cbuildbot: Log timing of GenerateUploadJSON.

Created with:
  roll-dep src/third_party/chromite
BUG=821930, 822517 , 821615 ,None,821618,821227,None,821664,821930,None,815377,747385,461595,821664,821664,811989,819419,821618,820305,821664,821664,819017,813442,707803,811989


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib6aaddf338307e994865a092ecb322a432148692
Reviewed-on: https://chromium-review.googlesource.com/967273
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543855}
[modify] https://crrev.com/b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5/DEPS

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/8d50e94a5bc99962d8665422cd9b5d6ac53be508

commit 8d50e94a5bc99962d8665422cd9b5d6ac53be508
Author: Manoj Gupta <manojgupta@google.com>
Date: Mon Mar 19 04:03:54 2018

chromite: Fix a bug in fuzzer gs_path.

Drop the trailing '/' in the buzzer gs bucket.
This results in an extra '/' directory being created.

BUG= chromium:822517 
TEST=run_tests

Change-Id: I2fe2c238552ac7ddfcc46b7e04df890ac30776bc
Reviewed-on: https://chromium-review.googlesource.com/966497
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/8d50e94a5bc99962d8665422cd9b5d6ac53be508/cbuildbot/config_dump.json
[modify] https://crrev.com/8d50e94a5bc99962d8665422cd9b5d6ac53be508/cbuildbot/chromeos_config.py

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/979aab9094edd8d473a783b1ecc3dcfb100a8dcc

commit 979aab9094edd8d473a783b1ecc3dcfb100a8dcc
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Mar 19 05:38:44 2018

Roll src/third_party/chromite/ d49af8335..8d50e94a5 (1 commit)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/d49af833556c..8d50e94a5bc9

$ git log d49af8335..8d50e94a5 --date=short --no-merges --format='%ad %ae %s'
2018-03-18 manojgupta chromite: Fix a bug in fuzzer gs_path.

Created with:
  roll-dep src/third_party/chromite
BUG= 822517 


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ia4cd4492e1197f1942fcc6b91dfa489f50de2a3b
Reviewed-on: https://chromium-review.googlesource.com/966500
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543976}
[modify] https://crrev.com/979aab9094edd8d473a783b1ecc3dcfb100a8dcc/DEPS

Sign in to add a comment